Comments (4)
@frigus02 Hi i know what problems you get and thanks for helping me out. I get one problem though with the normalizeColor i think that i implements it wrong but it seems not to make really a difference when i replace the normColor, could you show me more of how you implemented that?? Thanks!!
from holocolorpicker.
Hi. Of course I can. It was not really well explained. I also have to say, that my first fix did not overall fix this. But I think I'm coming closer. So here is what I have now. Both methods are from the ColorPicker
class.
In setColor
I edited lines 15-19 and also added line 25.
In normalizeColor
I added lines 33-36. This is different, from what I wrote before. The intention of this is to remove the changes, that saturation and value make to red, blue and green. This seems to work for me now.
(Line numbers refer to the linked gist.)
from holocolorpicker.
Just found out, I had another bug in my solution. In setColor
of ColorPicker
class, mOpacityBar.setColor()
has to be called before mSVBar.setColor()
. I updated the gist. Sorry, hopefully this was the last change.
EDIT: And before the the different return statements in calculateColor
the variable mColor
has to be set.
from holocolorpicker.
I added a bit more functionality. In specific, I customized the views, to resize and better fit on small devices. It's a bit more code and make a pull request for this.
from holocolorpicker.
Related Issues (20)
- value = -1? HOT 3
- Taps don't trigger a color change, yet they move the pointer. HOT 1
- Color selection to string HOT 4
- Bar orientation HOT 2
- How can i set the SaturationBar and OpacityBar?
- can not disable the view HOT 1
- About bit HOT 1
- Mirror bars
- Can this libarary add activity call and color result when user select color?
- Can this library pick up color from a circle/ring image HOT 1
- Is it possible to select white as color? HOT 1
- No OnColorSelectedListener-event on SVBar
- Could you please make a release tag?
- How do I use this in my android studio project. I'm new to android studio.
- SaturationBar not properly picking up Value HOT 6
- HoloPicker Size parameters not in documentation
- Will HoloColorPicker design yield less possible color choice than a solid full circle? HOT 2
- This library has a lot of bugs but...
- How to use OnClickListener for Colorpicker HOT 1
- Make focusable as for TV layer
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from holocolorpicker.