Colors are not always correct

[larswerkman]

Colors are not always correct

[LarsWerkman]

@frigus02 Hi i know what problems you get and thanks for helping me out. I get one problem though with the normalizeColor i think that i implements it wrong but it seems not to make really a difference when i replace the normColor, could you show me more of how you implemented that?? Thanks!!

[frigus02]

Hi. Of course I can. It was not really well explained. I also have to say, that my first fix did not overall fix this. But I think I'm coming closer. So here is what I have now. Both methods are from the ColorPicker class.

In setColor I edited lines 15-19 and also added line 25.

In normalizeColor I added lines 33-36. This is different, from what I wrote before. The intention of this is to remove the changes, that saturation and value make to red, blue and green. This seems to work for me now.

(Line numbers refer to the linked gist.)

[frigus02]

Just found out, I had another bug in my solution. In setColor of ColorPicker class, mOpacityBar.setColor() has to be called before mSVBar.setColor(). I updated the gist. Sorry, hopefully this was the last change.

EDIT: And before the the different return statements in calculateColor the variable mColor has to be set.

[frigus02]

I added a bit more functionality. In specific, I customized the views, to resize and better fit on small devices. It's a bit more code and make a pull request for this.