Giter Site home page Giter Site logo

Comments (6)

tonyr59h avatar tonyr59h commented on August 20, 2024

Thanks for bringing this to my attention, I will look into it tonight. I used this feature in a product that was locked into portrait mode and neglected to test rotation.

from holocolorpicker.

mg6maciej avatar mg6maciej commented on August 20, 2024

I also noticed that vertical bars are thinner than original.

from holocolorpicker.

tonyr59h avatar tonyr59h commented on August 20, 2024

I decided to store and load the orientation bar in case it was changed during runtime. Of course that's not possible since I neglected to add a setter. You've got the right idea, the save/restore code should be removed. The orientation should not change during runtime anyway.

I'm not sure what the problem is with the width of the bar but I will investigate it and open a pull request when it's fixed.

from holocolorpicker.

tonyr59h avatar tonyr59h commented on August 20, 2024

I've made the changes required, tested the new build on my Galaxy S3, and opened a pull request (#43) into master.

from holocolorpicker.

mg6maciej avatar mg6maciej commented on August 20, 2024

Thanks! I would also remove private static final String STATE_ORIENTATION = "orientation"; as it is not used anymore.

from holocolorpicker.

axwell avatar axwell commented on August 20, 2024

Can you explain to a beginner what i have to change for this issue to be fixed ?
Thank you !

from holocolorpicker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.