Error when no function specified

[emurphy-9]

Error when no function specified

[emurphy-9]

Good stuff, I'll bash it out over the next few days anyway, make some new tests etc. 😄

[LasaleFamine]

And released 🎉 I've added you as contributor within the package.json. Thanks again, great work 👍

[emurphy-9]

Doesn't look too bad, I've got a very basic thing working right not.

Just wondering though are your tests currently working because after I did yarn install the tests that throw errors were failing. I fixed them by changing the error.message.search to error.stderr.search but I want to check that it's broken for you too.

Also I noticed that if you pass in multiple args to an export from the command line that it becomes an array. If we just add in the spread operator (...) we can separate the args again when we pass them to the exported function, just like make-runnable does. i.e.

const exportedFunc (args) => {
 let var1 = args[0];
 let var2 = args[1];
 // etc.
}

becomes:

const exportedFunc = (var1, var2) => {
 // function body
}

Personally I prefer this method, what do you think?

[LasaleFamine]

I don't know actually about the error in test, I need to check. Anyway with a PR the tests will run on Travis, so we can double check on different versions of Node.

The change make sense to me. The code was written time ago, so feel free to make some improvements if you want. 😄

[LasaleFamine]

Hi @emurphy-9, thanks for reporting this one. I think can be a nice improvement.
Do you want to try to raise a pull request for this? I'm a bit busy these days so I don't know when I will be able to make the change.

[emurphy-9]

@LasaleFamine Sure I can look into it, I haven't delved into your code but I can have a go. 😄