Giter Site home page Giter Site logo

Comments (5)

laurent22 avatar laurent22 commented on June 9, 2024

As before, the rich text editor's default font should match the note viewer's default font.

That's a good point - but should it? When I merged this change I indeed considered that it means the viewer and RTE will have different fonts, but maybe that's correct? The font editor should apply to the Markdown and Rich Text editor but the viewer is not an editor, so I guess it could stay as it was?

I'm not 100% sure though about all this actually, it was just my thoughts when I merged this pull request.

from joplin.

personalizedrefrigerator avatar personalizedrefrigerator commented on June 9, 2024

The font editor should apply to the Markdown and Rich Text editor but the viewer is not an editor, so I guess it could stay as it was?

Note that the default Rich Text editor font is now also different from the default markdown editor font (the markdown editor defaults to sans-serif, the Rich Text editor defaults to serif).

Edit: I've updated the issue title and description to reflect this.

from joplin.

personalizedrefrigerator avatar personalizedrefrigerator commented on June 9, 2024

It also seems to change the font in math and code regions:

screenshot: Math and code regions also use serif

Edit: I've created a separate issue for this: #10142

from joplin.

laurent22 avatar laurent22 commented on June 9, 2024

Thanks, although I'd be tempted to revert this change as it feels like it hasn't been well though out, and so that we can deal with it some other time.

from joplin.

ab-elhaddad avatar ab-elhaddad commented on June 9, 2024

Hi, I really apologize for these bugs 🙏🏼, but I am willing to fix them. I have already opened a PR fixing this issue and will go for the other issue.

from joplin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.