When marking a to-do as completed there's a slight delay before the list is updated

[laurent22]

When marking a to-do as completed there's a slight delay before the list is updated

[DarkFalc0n]

Which OS has this issue? I run joplin on Arch Linux and it is working instantly for me.

[laurent22]

All of them probably

[DarkFalc0n]

The only probable reason I could find is that the await Note.save(...) holds the event emit (at /packages/app-desktop/gui/NoteList/NoteList.tsx). The emit could be initiated before the save function, because the latter can take up some time for larger notes.

	const noteItem_checkboxClick = async (event: any, item: any) => {
		const checked = event.target.checked;
		const newNote = {
			id: item.id,
			todo_completed: checked ? time.unixMs() : 0,
		};
		await Note.save(newNote, { userSideValidation: true });
		eventManager.emit(EventName.TodoToggle, { noteId: item.id, note: newNote });
	};

[nebiyuelias1]

@DarkFalc0n - so just interchanging the two lines should fix it?

[DarkFalc0n]

Interchanging could lead to other cases of bad error handling where there is an exception and the note state couldn't be saved but the check will still update. The current order of functions makes more sense since any error in saving the note can be reflected even before updating the list (and the check mark)

[DarkFalc0n]

It needs more thought to be put into it

[G0maa]

@DarkFalc0n, I think you could interchange them & add e.g. try, catch block:

		eventManager.emit(EventName.TodoToggle, { noteId: item.id, note: newNote });
		try {
			await Note.save(newNote, { userSideValidation: true });
		} catch(e) {
			eventManager.emit(EventName.TodoToggle, { noteId: item.id, note: newNote });
		}

Maybe re-throw the error if needed.

[DarkFalc0n]

This could definitely work, lets see what others think of this

[G0maa]

Actually, I'm not sure if this particular NoteList.tsx component is being used, I think the one that's being used is NoteList2.tsx.

[laurent22]

That's right, we'll need to remove NoteList.tsx. I kept it there for some time just in case there's a major issue with the new note list

[G0maa]

There's a similar logic in NoteList2.tsx anyway 👀

joplin/packages/app-desktop/gui/NoteListItem/NoteListItem.tsx

Lines 53 to 59 in 06aa640

	if (changeEvent.elementId === 'todo-checkbox') {
	await Note.save({
	id: changeEvent.noteId,
	todo_completed: changeEvent.value ? Date.now() : 0,
	}, { userSideValidation: true });
	props.dispatch({ type: 'NOTE_SORT' });

But I'm not sure if it's really what's causing this behaviour, I added few hindered to-dos and it feels the same regardless of commenting the await or not.

[G0maa]

I've been playing around this by adding:

await new Promise(resolve => setTimeout(resolve, 2000));

before Note.save() and props.dispatch(), you can see the behavior in this gif:

I think the solution I suggested above can't be applied here, props.dispatch() depends on the Note.save().