Giter Site home page Giter Site logo

Comments (10)

graphit0 avatar graphit0 commented on May 18, 2024

I couldn't reproduce this behaviour

Firefox 124 Nightly
Brave 1.62 Chromium 121
Joplin 2.14.14
Clipper 2.11.2
ubuntu 22.04

  • Firefox opens new window with URL: joplin://x-callback-url/openNote?id=588ee103a214443ebd89d1039b26b762
  • opening the note from the web clipper opens a new window in Firefox with garbage URL

This URL is external link to clipped note and should open dialogue to run Joplin window with created note

Firefox
image
Brave (chromium)
image

Could you be possibly running portable version of Joplin?

from joplin.

bgoodmansf avatar bgoodmansf commented on May 18, 2024

I have tried this on both Windows 10, Windows 11 and Fedora 39 with the same result. I am running the non-portable version of Joplin on Windows. Here is a screenshot after clipping a note on Fedora.
Screenshot_20240216_083017

from joplin.

graphit0 avatar graphit0 commented on May 18, 2024

Could you report what application is assigned to open joplin:// links

In firefox: General -- Applications
image

from joplin.

bgoodmansf avatar bgoodmansf commented on May 18, 2024

On Fedora 39, my FIrefox settings looks the same as yours (Use Joplin (default).

Note that the note is opened correctly in Joplin. But the window/tab is left open in Firefox. In Chrome, the window/tab goes away.

from joplin.

graphit0 avatar graphit0 commented on May 18, 2024

So the issue here is the tab not closing or there's no warning that you may close the tab afterwards?
Or there's some other expected behaviour?
Gotta clarify that in expected behaviour of original issue.

from joplin.

bgoodmansf avatar bgoodmansf commented on May 18, 2024

From the user's perspective, they asked to open a note in Joplin. Instead a tab or window opens in the browser.

I don't know if opening a browser window is a required part of the sequence, but it is definitely not what the user expects. It may be that Chrome also opens a browser window, but it gets closed.

I will add more to the expected behavior.

from joplin.

graphit0 avatar graphit0 commented on May 18, 2024

Okay, I can see that now, thanks. Would be nice to update the title as well 👀

from joplin.

bgoodmansf avatar bgoodmansf commented on May 18, 2024

The title seems correct to me. The problem is that there is window of junk opened in Firefox.

What do you think would be a better description?

from joplin.

graphit0 avatar graphit0 commented on May 18, 2024

I see. In my view, opening new tab with external x-callback-url is expected behavior. Joplin uses it to communicate with other applications -- for example you can create a desktop shortcut that would open a particular note using this kind of link.

I believe Joplin expects user to interact with such links, so maybe there's a point of making it somehow more intuitive and easy. That said, I believe x-callback-url is not garbage 😅 (not to mention calling it that might be offensive to people who developed it -- who has main knowledge to fix it)

To keep this particular issue focused on functionality (i.e. not to deal with UX -- without a designer, it's difficult to work on such issues) I suggest the following title

Web Clipper: "Open newly created note" doesn't close its tab after redirect in Firefox

from joplin.

bgoodmansf avatar bgoodmansf commented on May 18, 2024

I am certain Joplin does NOT expect the user to interact with the tab because it is deleted when using Chrome.

from joplin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.