SlimerJS not compatible with Firefox 62

[kaosko]

SlimerJS not compatible with Firefox 62

[kaosko]

Not quite enough just switch to newChannel2 and provide null for the rest of the arguments (even though this post seems to suggest so: https://stackoverflow.com/questions/3772788/how-to-load-file-from-inside-firefox-plugin). Perhaps need to use newChannelFromURI2 instead since we have an URI argument. For my purposes though, I just disabled coffeescript in slConfiguration.jsm and that did the trick to make it working with FF 62.

[marcwaz]

please fix it +1

[MarkR42]

Hi, I found that passing nulls to newChannel2 isn't (quite) sufficient, instead, this seems to work with FF62:

…

--- a/ksn-feeder/slimerjs-mod/src/modules/slUtils.jsm +++ b/ksn-feeder/slimerjs-mod/src/modules/slUtils.jsm @@ -177,7 +177,9 @@ slUtils.readSyncStringFromFile = function readSyncStringFromFile (file) { } slUtils.readChromeFile = function readChromeFile(url) { - let channel = ioService.newChannel(url,null,null); + let channel = ioService.newChannel2(url,null,null,null, + Services.scriptSecurityManager.getSystemPrincipal(), + null, null, null); let input = channel.open(); scriptableStream.init(input); Which is copied from some code I found in Firefox test suite. Mark

On Fri, 14 Sep 2018 at 18:48, Kalle Korhonen ***@***.***> wrote: Seems like you can just switch to newChannel2 and provide null for the rest of the arguments ( https://stackoverflow.com/questions/3772788/how-to-load-file-from-inside-firefox-plugin ). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#707 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABmsUtAxtVT_MyzxUuITXiiHkpfw0JpIks5ua-wDgaJpZM4Wprmb> .

[marcwaz]

@MarkR42 could you provide a Dockerfile sample ?
For me it doesn't work with FF62.

[MarkR42]

I can't provide a Dockerfile sample. For me it works with this change (plus change application.ini to allow Firefox 62)