Comments (5)
Indeed that's actually an issue and you will notice that [Gc.full_major] is actually called pretty often in the code. I'm not sure whether this is actually necessary, a [Gc.minor] may be enough and quite faster.
I would not expect this to be very long compared to running some backward step on your gpu but maybe in some use case it's significant.
Anyway there is no perfect way around it, rust has these linear/affine types that help a lot but there is nothing like this in ocaml. That said I think that some recent version of ocaml added a way to tell the gc about how much 'resource' some opaque pointer is consuming and that should work well for this use case, I haven't played with it yet but that would probably be a nice thing to have.
from ocaml-torch.
I would not expect this to be very long compared to running some backward step on your gpu but maybe in some use case it's significant.
You're right, currently "Gc.full_major" seems slow, but only relative to doing backpass on MNIST. I'm sure on larger datasets it'll be better.
Do you know how PyTorch handles this problem? My OCaml code, without manual Gc.full_major, will often throw exception of unable to allocate mem on CUDA. I haven't run into this issue in PyTorch. Does PyTorch catch the exception, run a full GC, and continue? [I'm not sure, just guessing.]
from ocaml-torch.
Speaking of which -- can the OCaml bindings do this? Where if something fails to allocate it does:
fn handle_fail_alloc =
run full gc;
try alloc again;
if still fail, die; else continue;
from ocaml-torch.
Python uses ref counting for memory management rather than only a gc (there may be a gc involved to find cycles?) so this is not an issue there.
Handling failed allocation by running the gc is probably not very straightforward do I'm afraid. Most code invariants break when you don't have memory. When it's gpu memory that may be less of an issue but it's still probably quite difficult.
from ocaml-torch.
-
Right, IIRC Python is RefCount + cycle detector.
-
I know close to nothing about OCaml VM and defer to you on this issue.
Thanks for the detailed response, looks like Caml.Gc.full_major
it is.
from ocaml-torch.
Related Issues (20)
- Is it possible to download pretrained model weights from the python version of pytorch and use it in ocaml-torch? HOT 2
- Mnist example - crashes at runtime HOT 2
- Torch installation not working with ubuntu HOT 2
- Getting Issue with mnist tutorials HOT 5
- Is there anthing equivalent to load and save model in ocaml torch HOT 4
- Support for CUDA 11 HOT 3
- Mini-Dalle Example HOT 2
- How to load a npz file to a tensor? HOT 1
- diffusers-ocaml HOT 3
- Custom training HOT 1
- Setting slices of a tensor: what is the equivalent of (python) x[i,:,:] = y HOT 7
- debugging out-of-memory exception HOT 12
- Install Ocaml-Torch failed on macos with M1 chip HOT 2
- installing gpu accelerated version on macos
- most exceptions from libtorch not caught (macos) HOT 24
- installing on macos in presence of other pytorch instances HOT 11
- .pt file to .ot file - Anyway to skip the conversion HOT 12
- How to extend Tensor.t with additional functions? HOT 3
- Issues with install on MacOS, with ARM architecture
- undefined symbol: ffi_type_void, version LIBFFI_BASE_7.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ocaml-torch.