vagrant upload fails on ubuntu1804 box when uploading a directory

[lavabit]

vagrant upload fails on ubuntu1804 box when uploading a directory

[vohi]

PS: this is with vagrant 2.2.3 and VirtualBox 5.2.26 (the latter shouldn't matter assuming that this is done via scp rather than VirtualBox's file uploading mechanism).

[ladar]

@vohi I did some digging and couldn't find any changes in the build scripts between 1.8.54 and 1.9.2 that would cause this. However, each new box version includes distro updates, and there was a recent update to the OpenSSH package that appears to match your error message:

http://salsa.debian.org/ssh-team/openssh/commits/master

Specifically the following commits:

https://salsa.debian.org/ssh-team/openssh/commit/125924e47db3713a85a70e0f8d6c23818d2ea054
https://salsa.debian.org/ssh-team/openssh/commit/f3357d7941c5ccc3d772e4461b1e2d137909670b

It would take more digging, but assuming the OpenSSH patch is valid, I'm guessing the bug lies with the Vagrant net-ssh package, and how it is sending directory names.

I'll leave this issue open for now, but you probably want to open up linked bug reports with Vagrant and the Debian SSH team.

[ladar]

I did a little testing, and found this combination worked for me. Assuming the directory being uploaded is "scripts" and you want to upload it to the default, "/home/vagrant/":

find scripts/ -type d -exec vagrant ssh -c 'mkdir -p {}' \;
find scripts/ -type f -exec vagrant upload {} \;

Basically scp fails if it's asked to upload to a path that doesn't exist at the destination, so the first command creates all of the necessary subdirectories, and the second uploads each file to the right place.

[vohi]

Thanks a bunch @ladar! I'll work around this for now in my script, and have opened a ticket with the Vagrant project.

[ladar]

@vohi this Vagrant pull request claims to have fixed this issue, and the upstream bug is closed. Can you test? Unless I hear otherwise from you, I'll assume it's safe to close this issue.

[vohi]

Not going to be able to run vagrant from upstream for a while, but fix looks like it would address this issue. Either way, ok to close this issue since there's nothing wrong with the boxes.