Weird tray icon (zoom) behavior

[keshto]

Weird tray icon (zoom) behavior

[LBCrion]

I just committed a fix. Can you try the latest git please?

…

On Thu, 23 Mar 2023, 01:47 Keshto, ***@***.***> wrote: I don't have that many tray icons. However, Zoom (the application) tray icon on right click popups a window with a menu (see attached picture) in the middle of the screen. On left click popups same menu correctly. Desired behavior (do what waybar does): - left click shows/focus client - right click shows menu [image: image] <https://user-images.githubusercontent.com/766237/227077813-46e6113e-3d78-4e46-81a9-84e61fc31d49.png> — Reply to this email directly, view it on GitHub <#78>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASHPFFE6Z373U6J2CGCL4XDW5OTRVANCNFSM6AAAAAAWESFVRQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[keshto]

Thanks for the quick turn around!
It does indeed fix the problem above, but does introduce other issues:

• left click on nm-applet should show what is not right click, and right clicking on nm-applet should show (attached image)
  
• the left/right clicks for zoom is accurate
• slack's normal left click menu now only shows on right click only (left click does nothing)

[LBCrion]

Thank you for testing this. Can you please check if middle click gets you the menu you expect to see under either button? I suspect we may be running into the flipside of https://bugs.launchpad.net/ubuntu/+source/libappindicator/+bug/1910521

[keshto]

Middle click does nothing

[LBCrion]

I just tried nm-applet 1.30 on my machine. I get the menu shown in the screenshot above. in sfwbar, I get it on a right click, in waybar, I get this menu on both left click and right click. Do you get another menu on left click in waybar? Which version of nm-applet do you use?

[keshto]

network-manager-gnome/testing,unstable,now 1.30.0-2 amd64 [installed] so looks like same version. On waybar I don't get the menu in the screenshot above but instead the one i currently get on right click in sfwbar (for both left and right click). In JWM I get the menu in screenshot on right click.

[keshto]

This "left click doing nothing right click showing what left click should be" behavior is also happending for package-update-indicator/testing,unstable,now 8-2 amd64 [installed] so don't think it is a nm-applet thing.

[LBCrion]

Ok, so the only difference from waybar is the left click? waybar pops up the same menu as on right click and sfwbar does nothing?

JWM provides a freedesktop tray I believe. That's an X11 based protocol and won't work natively on wayland. The only way to replicate this is to use xembedsniproxy and Xwayland (this will produce ugly looking icons and menu's popping up in the center of the screen).

[keshto]

Ok, so the only difference from waybar is the left click? waybar pops up the same menu as on right click and sfwbar does nothing?

Correct.

JWM provides a freedesktop tray I believe. That's an X11 based protocol and won't work natively on wayland. The only way to replicate this is to use xembedsniproxy and Xwayland (this will produce ugly looking icons and menu's popping up in the center of the screen).

Don't think that is the right solution. You did mention that you saw (attached) on right click? If so on left click you should see something else and if that is the case you have correct behavior.

[LBCrion]

I see the above (or a very similar menu at least) on both left and right click in waybar.

The left click behaviour looks like a difference between the StatusNotifierIcon spec and the libappindicator implementation of the spec. Per spec, the tray (StatusNotifierHost) should send Activate event on left click, unless application sets ItemIsMenu property to true, in which case ContextMenu event is sent or menu is popped up. libappindicator seems to popup a menu on left click regardless of ItemIsMenu setting (which makes sense since bug report I linked earlier mentions that libappindicator doesn't support the Activate event).

[keshto]

In waybar the left and right open the same menu which is not the one above. The one above is the result of the right click on x11 (I haven't tried xfce panel or something similiar). The left click opens up a list of wireless networks where as the right should open the above. The update app indicator has same effect with sfwbar (left and right click both bring up the normally left click only menu and dont have a way to bring up the normal right click menu)

…

On March 23, 2023 10:20:56 PM UTC, LBCrion ***@***.***> wrote: I see the above (or a very similar menu at least) on both left and right click in waybar. The left click behaviour looks like a difference between the StatusNotifierIcon spec and the libappindicator implementation of the spec. Per spec, the tray (StatusNotifierHost) should send Activate event on left click, unless application sets ItemIsMenu property to true, in which case ContextMenu event is sent or menu is popped up. libappindicator seems to popup a menu on left click regardless of ItemIsMenu setting (which makes sense since bug report I linked earlier mentions that libappindicator doesn't support the Activate event). -- Reply to this email directly or view it on GitHub: #78 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***>

[keshto]

X11 left click menu is different then the one above. The one above should be the right click

[LBCrion]

Ok, it looks like with the X tray (freedesktop tray) nm-applet uses 2 menu's, one for connections and one for settings. With StatusNotifierItem tray, it combines them into a single menu. This is because SNI only supports one menu (second menu can be implemented by the applet itself, but it can't be positioned gracefully). So in wayland we'll only have the one menu version.

This still leaves the question of left mouse button click. I'm not too keen to emulate the libappindicator behaviour, as it goes against the SNI spec and would break applets that actually use Activate event. It would be possible to add a tray property to allow switching the behaviour between SNI spec and libappindicator implementation.

[Consolatis]

That sounds like a good approach. Defaulting to SNI spec behavior seems like the best thing to do.

[keshto]

Is waybar not following the SNI spec because it uses left and right for the same action for nm-applet which is more intuitive imo. Maybe follow SNI, if there is no left click action then invoke right click?

I will report shortly back about different indicator.

[keshto]

Hmm, either SNI spec is broken or the way people implementing their indicators... package-update-indicator has two different menus depending on left and right click. Waybar shows the same on both left and right click. Sfwbar show only on right click.
Both don't show the right click menu to quit out.

If someone had xfce4 panel or something more mainstream we could better compare the behavior.

[LBCrion]

Do you see the two menus in jwm? If so, I would expect this is using the Freedesktop tray as well.

…

On Fri, 24 Mar 2023, 18:54 Keshto, ***@***.***> wrote: Hmm, either SNI spec is broken or the way people implementing their indicators... package-update-indicator has two different menus depending on left and right click. Waybar shows the same on both left and right click. Sfwbar show only on right click. Both don't show the right click menu to quit out. If someone had xfce4 panel or something more mainstream we could better compare the behavior. — Reply to this email directly, view it on GitHub <#78 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASHPFFDOFEBGRFU6ZZDPX73W5XUVBANCNFSM6AAAAAAWESFVRQ> . You are receiving this because you commented.Message ID: ***@***.***>

[keshto]

Tested on plasma (wayland) and it looks like tray icons in general are just lame for wayland. I think if we do as above ie. follow SNI spec and set rightclick action to left click (if an action does not exist) in other words mimic waybar's functionality we should be good.

[LBCrion]

Ok, I looked at how Waybar handles this and it looks like it just assumes that ItemIsMenu set tot TRUE unless it's set as FALSE. Since libappindicator tray items don't have ItemIsMenu property defined, it handles left click as a menu popup. I changed this property to be TRUE by default and we should now have the same behaviour as with waybar.

[keshto]

Tested and it all cherry! Thanks again!