Giter Site home page Giter Site logo

Comments (9)

lbrndnr avatar lbrndnr commented on July 18, 2024

You mentioned that you replaced the images with labels which still resulted in sluggish animations. Did you already figure out why this is? I obviously tried this on some devices, one of which was the iPod 4 gen which worked fairly well...

from imagepickersheetcontroller.

csilouanos avatar csilouanos commented on July 18, 2024

No man I didn't figure out why that happens.. I don't think it's my phone because iMessages image picker works as expected. I tried creating a new project and pod your library but I faced the same issue.

from imagepickersheetcontroller.

csilouanos avatar csilouanos commented on July 18, 2024

By the way, sorry for asking, but how did you test it on iPod 4? The highest version that is supported by this model is iOS 6.

from imagepickersheetcontroller.

lbrndnr avatar lbrndnr commented on July 18, 2024

@csilouanos 5 gen whatever, the one that supports iOS 8. That's so weird though. Did you do the time profiling?

from imagepickersheetcontroller.

csilouanos avatar csilouanos commented on July 18, 2024

I tried it but for some reason I can't start the time profiling. Is the counters tool isn't it?

from imagepickersheetcontroller.

csilouanos avatar csilouanos commented on July 18, 2024

Hey man, so I found the issue! The problem is that when user has hundreds of images (in his device) the scroll is getting bad. On my device I have around 1600 images! That's why the problem exists.

On top of that, I think this library suppose to fetch only the recent images. That's why, maybe, on your end (even with iPod) was working great.

In my opinion I think you should change that bit of code where you are fetching the images in the first place. So the method fetchAssets() should fetch the number of images depending maybe on a constant that the developer can set.

Even Apple is not doing that (fetching all the user's images). What they are doing, is that they fetched just the recent images!

I changed that bit of code on your library and on my phone finally works great!

If I have any other issue I will let you know! Thank you very much for your time and your help!

from imagepickersheetcontroller.

lbrndnr avatar lbrndnr commented on July 18, 2024

@csilouanos Ooh, that's why! Yeah I always only have a couple hundred images. Will fix this tonight! Thanks for your info :)

from imagepickersheetcontroller.

csilouanos avatar csilouanos commented on July 18, 2024

My pleasure!

from imagepickersheetcontroller.

lbrndnr avatar lbrndnr commented on July 18, 2024

Okay, restricted the loaded assets to 50. I published v0.1.2 that you should update to via Cocoapods or Carthage, whatever you like :) Thanks again for pointing this out.

from imagepickersheetcontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.