Comments (9)
You mentioned that you replaced the images with labels which still resulted in sluggish animations. Did you already figure out why this is? I obviously tried this on some devices, one of which was the iPod 4 gen which worked fairly well...
from imagepickersheetcontroller.
No man I didn't figure out why that happens.. I don't think it's my phone because iMessages image picker works as expected. I tried creating a new project and pod your library but I faced the same issue.
from imagepickersheetcontroller.
By the way, sorry for asking, but how did you test it on iPod 4? The highest version that is supported by this model is iOS 6.
from imagepickersheetcontroller.
@csilouanos 5 gen whatever, the one that supports iOS 8. That's so weird though. Did you do the time profiling?
from imagepickersheetcontroller.
I tried it but for some reason I can't start the time profiling. Is the counters tool isn't it?
from imagepickersheetcontroller.
Hey man, so I found the issue! The problem is that when user has hundreds of images (in his device) the scroll is getting bad. On my device I have around 1600 images! That's why the problem exists.
On top of that, I think this library suppose to fetch only the recent images. That's why, maybe, on your end (even with iPod) was working great.
In my opinion I think you should change that bit of code where you are fetching the images in the first place. So the method fetchAssets() should fetch the number of images depending maybe on a constant that the developer can set.
Even Apple is not doing that (fetching all the user's images). What they are doing, is that they fetched just the recent images!
I changed that bit of code on your library and on my phone finally works great!
If I have any other issue I will let you know! Thank you very much for your time and your help!
from imagepickersheetcontroller.
@csilouanos Ooh, that's why! Yeah I always only have a couple hundred images. Will fix this tonight! Thanks for your info :)
from imagepickersheetcontroller.
My pleasure!
from imagepickersheetcontroller.
Okay, restricted the loaded assets to 50. I published v0.1.2 that you should update to via Cocoapods or Carthage, whatever you like :) Thanks again for pointing this out.
from imagepickersheetcontroller.
Related Issues (20)
- Crash. This application is not allowed to access Photo data. HOT 1
- IOS 10: Photo taken from the camera: Secondary Handler does not get called HOT 2
- Sorry, how can I use the swift 3 version? HOT 1
- "Add Comment" HOT 5
- No animation in HOT 1
- First button in actionSheet is animated with scale
- Incompatiable with Xcode 8.0 beta 2 HOT 2
- block main thread in ImagePickerSheetController.cellForItemAtIndexPath HOT 1
- Swift 3 HOT 1
- view of memory leaks HOT 1
- Cocoapods org not update 0.9.2? HOT 4
- crash if display this controller in popover on iOS 9.3.3
- How about the Swift3 Compatibility? HOT 2
- The app crash on Xcode8.0 iOS10 within ImagePickerSheetController. HOT 2
- Swift 3.0 support HOT 1
- [Version Supported] 8.0 HOT 6
- Swift 3.0 branch HOT 1
- Why not merge Swift3.0 to the main branch? HOT 1
- On the Swift3 branch: Denying access to photo library, and presenting an alertController on top of presented image picker sheet => crash HOT 7
- On the Swift3 branch: Setting .maximumSelection = 1 and then attempting to select multiple images => app crashes HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imagepickersheetcontroller.