FTP port hardcoded?

[ldab]

FTP port hardcoded?

[TranquilloCosta]

No reason for been hardcoded, added: 29bbefe

@mikestarkenburg mikestarkenburg commented on 31 Jul 2020 that the port number is hard coded = 21 in your library. He wanted to suggest to make it free to choose when initializing the client.

There is a duplicate of the initialisation definition where the second overwrites the first. They differ in port = _port; and port = 21; Therefore, the port can only be changed within the source code of the library:

ESP32_FTPClient::ESP32_FTPClient(char* _serverAdress, uint16_t _port, char* _userName, char* _passWord, uint16_t _timeout, uint8_t _verbose){ userName = _userName; passWord = _passWord; serverAdress = _serverAdress; port = _port; timeout = _timeout; verbose = _verbose; }

ESP32_FTPClient::ESP32_FTPClient(char* _serverAdress, char* _userName, char* _passWord, uint16_t _timeout, uint8_t _verbose){ userName = _userName; passWord = _passWord; serverAdress = _serverAdress; port = 21; timeout = _timeout; verbose = _verbose; }

[ldab]

No reason for been hardcoded, added: 29bbefe

[ldab]

Thanks for you comment but it’s incorrect, please refer to the following link which explain the implementation https://en.cppreference.com/w/cpp/language/default_arguments