Giter Site home page Giter Site logo

Comments (9)

indigoxela avatar indigoxela commented on July 20, 2024 6

it is pretty clear that Leaflet.draw is not maintained anymore

What a pity! Is there any way to keep it (minimally) supported? (It still works with the current Leaflet 1.8.0 dev version.)

Leaflet-Geoman may be a cool project, but it's not a drop-in replacement and would require to completely rewrite integration code from scratch.

Github lists a usage of 3.5k. That may not be huge, but it's still significant.

from leaflet.draw.

torrid33 avatar torrid33 commented on July 20, 2024 2

Oh boy... just integrated leaflet.draw on a major project... now very nervous...

from leaflet.draw.

Falke-Design avatar Falke-Design commented on July 20, 2024 1

... maybe we can find together a way to do a "drop-in replacement" from Leaflet-Draw to Leaflet-Geoman.

If that would be possible... sure! Geoman is a cool project, but appears substantially different to me. Not sure if I could provide much help to get that task done - my js skills are rather limited.

I will take a look into it, but this will take some time.

I know, that's out of scope of this issue here - but could breaking changes in Leaflet (core) be postponed to a major release like 2.x? I'm not sure if people expect such a breaker in a minor release, or even worse - in a bug release (like possibly 1.9.3).

Yes that is the plan, we are currently working on version 2.0 and that is the reason for removing the deprecated methods. Changes like that should not be included in the v1 branch.

from leaflet.draw.

indigoxela avatar indigoxela commented on July 20, 2024

With a recent commit in Leaflet, this module will break (_flat got removed).
A PR is available for years now, but there's no maintenance, so it never got merged #892

The reason why I chose Leaflet.draw in my integration was that it's prominently linked on this organization's page: https://github.com/Leaflet

But obviously it's neither an officially supported plugin, nor maintained at all. I'm not sure how many other people misunderstood the status of this plugin the way I did, but I see a "used by 4k" in the sidebar of the main page, so it's not just me. And 4k+ seems significant usage to me.

Breaking Leaflet.draw will probably mean that many integrations can't keep up with the main library anymore. At least without a major rewrite - if that's possible at all.

from leaflet.draw.

Falke-Design avatar Falke-Design commented on July 20, 2024

I'm not 100% sure but it looks like, there was a time, where big plugins where moved to the Leaflet Project. But the plugins kept maintained by the origin maintainers.

@indigoxela maybe we can find together a way to do a "drop-in replacement" from Leaflet-Draw to Leaflet-Geoman.

from leaflet.draw.

indigoxela avatar indigoxela commented on July 20, 2024

... maybe we can find together a way to do a "drop-in replacement" from Leaflet-Draw to Leaflet-Geoman.

If that would be possible... sure! Geoman is a cool project, but appears substantially different to me. Not sure if I could provide much help to get that task done - my js skills are rather limited.

I know, that's out of scope of this issue here - but could breaking changes in Leaflet (core) be postponed to a major release like 2.x? I'm not sure if people expect such a breaker in a minor release, or even worse - in a bug release (like possibly 1.9.3).

from leaflet.draw.

indigoxela avatar indigoxela commented on July 20, 2024

Back to the initial idea - a statement about maintenance.

Maybe nobody realized that Leaflet.draw is seeking a new maintainer? (As an optimist I prefer "seeking new" over "has no".) πŸ˜‰

This project is used by 4k+ other projects, has 1.8k stars and 103 watchers. It's totally possibly that someone volunteers to do some basic update and maintenance work just to keep their own (depending) project running. Currently it probably doesn't require too much work to keep it compatible with a recent Leaflet core. 🀞

from leaflet.draw.

y1324 avatar y1324 commented on July 20, 2024

we are currently working on version 2.0

Does the 2.0 version refer to 'lefaet'? And are there any plans or to-dos for the 2.0 version currently? I would like to know about the progress, and if it's possible for me to get involved in the development of the 2.0 version.

@Falke-Design

from leaflet.draw.

indigoxela avatar indigoxela commented on July 20, 2024

To get Leaflet.draw working with the most recent Leaflet, I had to add some overrides.

I'll probably (have to) do something similar for Leaflet 2.0 to keep my integration up and running, but it looks feasible.
I'd still prefer some maintenance on Leaflet.draw (instead of working around compatibility problems in integrations), if that's possible.

from leaflet.draw.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.