Comments (5)
It might be simpler to just support any arguments, such as --wfail
from lean-action.
Within the action lake is run on different occasions:
lake exe cache get
lake build
lake test
lake exe runLinter
Do I understand correctly that there will be cases where each of these require different arguments? Consequently it would be fine to support passing any arguments but the action needs 4 different inputs to correspond to each of the different occasions when lake runs?
from lean-action.
It might be simpler to just support any arguments, such as
--wfail
👍 I agree this is much simpler and more flexible. I think a build-options
input which allows for lake build {build-options}
should do the trick.
Do I understand correctly that there will be cases where each of these require different arguments? Consequently it would be fine to support passing any arguments but the action needs 4 different inputs to correspond to each of the different occasions when lake runs?
Hmm, this is a good point. It seems feasible that users would arguments, such as --wfail
, in any of these instances.
Another potential use case would be if a user wants to run all lake commands with certain arguments such as --wfail
.
Do others know of existing projects which pass parameters to the other lake commands in their CI? For instance does lake exe cache get
ever get called with args? For the sake of simplicity, we might should limit the input interface to support args for the commands which have known use cases and expand as needed.
from lean-action.
🤔 Small survey of uses:
lake -R -Kenv=dev build
is used in many projects for building the project docs. E.g., FLTlake build -Kwerror
used in batterieslake -Kenv=dev exe cache get
is used in LeanAPAP
from lean-action.
I created #27 which adds this functionality specifically for lake build
so we can support the use case in `batteries.
from lean-action.
Related Issues (20)
- Support repositories with subdirectory Lean packages
- v1-beta release HOT 1
- Add an option to disable GitHub caching
- Mathlib detection prints unnecessary error when lakefile.toml not present
- Update the lint step to use the more flexible `lake lint`
- Automatically check if test runner is available HOT 18
- Leverage output parameters for `lake build` and `lake test` steps to to verify the expected steps ran during a test
- Leverage Lake's API to determine if a package is downstream of Mathlib
- build args default should be 'quiet' HOT 2
- Create `auto-config` input HOT 1
- bug: run `lake update` and `lean-action` gets an error HOT 18
- Parameterize functional tests by lean version.
- Problem about caching strategy for Lean HOT 5
- Save cache even if a build fails
- v1-beta.1 release HOT 2
- Update `RELEASING.md` based on improvements to release process
- Fix GitHub cache keys to reduce problems with the cache when updating Lean version
- (DRAFT RFC) Add support for building leanblueprint to lean-action
- install elan on windows HOT 2
- v1.0.0 release HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lean-action.