Giter Site home page Giter Site logo

Comments (5)

Kha avatar Kha commented on July 28, 2024

It might be simpler to just support any arguments, such as --wfail

from lean-action.

oliver-butterley avatar oliver-butterley commented on July 28, 2024

Within the action lake is run on different occasions:

  • lake exe cache get
  • lake build
  • lake test
  • lake exe runLinter
    Do I understand correctly that there will be cases where each of these require different arguments? Consequently it would be fine to support passing any arguments but the action needs 4 different inputs to correspond to each of the different occasions when lake runs?

from lean-action.

austinletson avatar austinletson commented on July 28, 2024

It might be simpler to just support any arguments, such as --wfail

👍 I agree this is much simpler and more flexible. I think a build-options input which allows for lake build {build-options} should do the trick.

Do I understand correctly that there will be cases where each of these require different arguments? Consequently it would be fine to support passing any arguments but the action needs 4 different inputs to correspond to each of the different occasions when lake runs?

Hmm, this is a good point. It seems feasible that users would arguments, such as --wfail, in any of these instances.

Another potential use case would be if a user wants to run all lake commands with certain arguments such as --wfail.

Do others know of existing projects which pass parameters to the other lake commands in their CI? For instance does lake exe cache get ever get called with args? For the sake of simplicity, we might should limit the input interface to support args for the commands which have known use cases and expand as needed.

from lean-action.

oliver-butterley avatar oliver-butterley commented on July 28, 2024

🤔 Small survey of uses:

  • lake -R -Kenv=dev build is used in many projects for building the project docs. E.g., FLT
  • lake build -Kwerror used in batteries
  • lake -Kenv=dev exe cache get is used in LeanAPAP

from lean-action.

austinletson avatar austinletson commented on July 28, 2024

I created #27 which adds this functionality specifically for lake build so we can support the use case in `batteries.

from lean-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.