Comments (4)
I propose that we actually just include this file regardless of which template the user has asked for. (Possibly with a switch to disable, but I'd very much like this on by default.)
from lean4.
I propose that we actually just include this file regardless of which template the user has asked for. (Possibly with a switch to disable, but I'd very much like this on by default.)
This makes sense to me. Now that lean-action automatically decides which CI steps to run based on check-test
and check-lint
users should be able to benefit from the default setup without touching the workflow file, i.e., they add a test driver or lint driver to their lake file and lake test
and lake lint
automatically get run by lean-action in CI. We could mention the automatic behavior in the documentation for @[test_driver]
and @[lint_driver]
.
If we always include the workflow file, the template / CLI option question above becomes irrelevant and I believe #4608 should be close to what we want. However if we do want to give users the option to disable the inclusion of the workflow file, the template / CLI option question still stands. The long option, something like --no-lean-action-workflow
still seems reasonable to me, however I defer to Mac here.
from lean4.
I created #4608 to get started on this. I am waiting for additional input before adding a way for the user to specify if the lake init/new
should create the ci workflow.
from lean4.
@austinletson Yep, #4608 seems exactly like what we want here! I left a code review with a few suggested tweaks over there. Also, mentioning the default workflow behavior in the documentation of test and lint drivers sounds like a good idea (though I think we can leave it for a follow-up PR).
from lean4.
Related Issues (20)
- `rw [def]` only works with first applicable equation lemma HOT 1
- default termination tactic: array_dec_dec tactic too eager, and too weak HOT 1
- bug: metavariable context being rolled back in simp
- typeclass inference crashes HOT 2
- Regression in inferring universe levels between v4.9.1 and v4.10.0-rc1 HOT 1
- decreasing_by goal with nested recursion mentions internal induction hypothesis
- RFC: remove `simpCtorEq` from the default simprocs HOT 1
- Broken Lake linking
- Incorrect arg count in a functional induction match arm, when WF def uses local variables. HOT 2
- Inferred type of a variable not propagated to earlier usages HOT 1
- Exponential behavior in compilation HOT 1
- "Failed to generate splitter"
- Changing `internal.minimalSnapshots` option leads to a panic
- Incrementality causes a weird error
- Lake doesn't ensure that module roots are disjoint HOT 3
- rw? sometimes inserts propext in suggestions
- Race condition in `lean_save_module_data` with concurrent `lean` processes HOT 1
- RFC: Turn "synthesized TC instance not defeq to expression inferred by typing" error into a disableable warning
- Make "synthesized TC instance not defeq to expression inferred by typing" error easier to debug
- Internal error due to lazy definition realization and backtracking
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lean4.