Mid Level Completed!

[learn-javascript-courses]

Mid Level Completed!

[ericelliott]

Great job! Here are some things I really liked:

• Good balance of unit tests vs functional tests.
  • Functional tests work great to ensure that critical happy paths are still working, and that UI buttons respond when clicked.
  • Unit tests work better to test the details and edge cases of the application domain logic.
  • Keeping fewer functional tests means that tests run faster, giving developers feedback in a tighter loop, which helps stay more productive.
• Your reducers looked very simple and easy to understand. Great work!
• Nice job with action creators. The function signatures and default assignments should give you great feedback if you have atom-ternjs installed (apm install atom-ternjs).
• Using Material UI was a wise choice. The UI looks professional!
• Good job debugging your Nightwatch setup!

Tips:

• All action types and action creators should be colocated with reducers. It doesn't make sense to duplicate them.
• Selecting and updating stuff by id is a common requirement, and can be abstracted out.
• Remember to handle loading and error states. See redux-dsm
• You should split saga worker tasks so that each worker handles a single action response workflow.