Comments (10)
From the looks of your terminal output, the difference seems to be quite subtle. It could the handling of newlines (\r\n
vs \n
) on Windows or do you have any special language configured?
Could you maybe try to debug the DOTSerializationTest
, and tell me what the actual difference between the two values is right before the violating check? (Any IDE with TestNG support should be able to this).
from automatalib.
You're absolutely right.
dotWriter.toString()
has \n
.
expectedWriter.toString()
has \r\n
.
How do I fix this?
from automatalib.
Great, thanks for the info. We will look into this. At this point I'm not sure yet, if this is an issue with the test or the way, the serializer works.
For now, if you're just interested in building the latest AutomataLib artifacts, you could run mvn clean install -DskipTests
or use the public snapshot artifacts
from automatalib.
@omarzd, could you maybe try to build https://github.com/mtf90/automatalib/tree/platformFixes? If this works for you, I can merge the changes in the main repo.
from automatalib.
@omarzd did you have the chance to test my branch?
from automatalib.
@mtf90 I just did. It gives the same error.
from automatalib.
@omarzd Hm, that is weird. I set up AppVeyor to have continuous integration on Windows platforms and merged the changes from my branch. As you can see, the build succeeds.
However, I did have to enable git's autocrlf
(so that the test files committed with \n
are checked out with \r\n
newlines). I assume you use the same configuration, because in your initial feedback you said, that the expectedWriter
(which is reading the file) contained \r\n
. Do the test files (e.g. serialization/dot/src/test/resources/graph.dot
) have correct newlines if you open them in an arbitrary editor?
from automatalib.
@mtf90 It looks like you merged the fix. I just set my git using git config --global core.autocrlf true
and compiled again and it passed the tests. Maybe the git config should be mentioned in the README.
Thank you
from automatalib.
@omarzd You haven't configured anything similar before? This makes me wonder how you ended up with \r\n
newlines in the first place (see your comment), because we mainly use UNIX systems for development (which only use \n
).
Anyway, it looks like everything is working out now. Thanks for raising this issue and reminding us to share more love for windows users :P.
Edit: Also, you probably don't have to set this as a global setting, which may interfere with other projects of yours. Apparently, we can also solve this by adding a .gitattributes
file to the repository, so that we can provide a proper out-of-the-box configuration. I'll have a look at that.
from automatalib.
@omarzd 3c1a0c5 added a .gitattributes
file which should automatically take care of correct, platform dependent newlines conversion, so you shouldn't need to manually configure anything for Automatalib. Although AppVeyor VMs still seem to require manual configuration via core.autocrlf
, I checked at least one Windows box where everything worked out-of-the-box.
from automatalib.
Related Issues (20)
- CompactMealyTransition does not extend MealyTransition HOT 5
- Substract current automaton size to Wp-method's maxDepth HOT 2
- Replace JSR305 annotations
- Write a parser for LTSmin formulae
- Incorrect characterizing set for Mealy machine HOT 3
- TAF writer does not enquote outputs of mealy machines
- DOTParsers.mealy() not parsing all transitions HOT 13
- Minimizer.minimize overload without start states is broken HOT 2
- CompactMoore HOT 9
- Deviation in the BBC functionality between (at least) LearnLib 0.14.0 and 0.16.0 HOT 2
- PaigeTarjanMinimization.minimizeDFA does not guarantee minimal result HOT 2
- Add support for Java 17 (LTS) to CI pipeline
- AUTParser only adds states with outgoing transitions
- How to minimize a chained mealy automata HOT 10
- M3C does not run on M1 MacBooks HOT 1
- Fail on javadoc warnings and improve documentation
- M3CParser fails when ID is a formula token
- IndexOutOfBoundsException in IncrementalMealyDAGBuilder when input word is longer than output word HOT 6
- IncrementalDAGBuilder fails for traces with cyclic repetitions longer than 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from automatalib.