Missing check for some XML tag name starting chars

[leethomason]

Missing check for some XML tag name starting chars

[leethomason]

Good catch.

[leethomason]

Just pushed the fix.

[akahlich]

I still get the failure with newly downloaded tinyxml2.cpp . I have attribute names that begin with underscores, so that is my interest (attributes beginning with colons I can take or leave at this point).

I found I needed to add to a line in "char* XMLElement::ParseAttributes( char* p )" in tinyxml2.cpp line 1325, where the first character of the attribute name is tested. The change I needed is from:

if ( XMLUtil::IsAlpha( *p ) ) {

to

if ( XMLUtil::IsAlpha( *p ) || *p == '_' ) {

[akahlich]

After looking at the code of "char* XMLElement::ParseAttributes( char* p )" a little more, perhaps a change of order of the 'if' tests after SkipWhiteSpace would allow parsing of the attribute as the last else condition in the chain. This would keep the notion of what a valid first character of an attribute is completely contained within StrPair::ParseName( char* p) as called by XMLAttribute::ParseDeep( char * p, bool processEntities ) rather than having to duplicate the notion within XMLElement::ParseAttributes( char* p ) before deciding to call XMLAttribute::ParseDeep( ... ).

Just a thought ...

[leethomason]

Could you provide a test case for xmltest.cpp? Pull request is best, although a bit of code snippet is good too. It's best if a bug has bounced like this if I have a simple, concrete test case to make sure it's resolved.

[leethomason]

Closing. Gone stale, although I'd still like a test case if this resurfaces.