Giter Site home page Giter Site logo

Comments (3)

leetreveil avatar leetreveil commented on August 22, 2024

The library was originally designed to keep the stream open for further processing. In hindsight, this was probably the wrong decision.

Happy to take a pull request that either, A) automatically closes the stream or B) updates the docs with info on how to close the file stream.

from musicmetadata.

pietrovismara avatar pietrovismara commented on August 22, 2024

Thinking more about it, you're decision is the most flexible. It happens often to do multiple things with streams, so closing it automatically would make musicmetadata less useful.
I'll go for B) update the docs and make you a pull request as soon as i can.

from musicmetadata.

leetreveil avatar leetreveil commented on August 22, 2024

Fixed in 7a56f48

from musicmetadata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.