Giter Site home page Giter Site logo

Comments (3)

lefos987 avatar lefos987 commented on September 9, 2024

We apply a lot of how the app should be structured, which is really good. I think we need to discuss if we actually move the tests in the same directory as the src code. Probably we should since it will allow us to logically group together all the files of a component and ideally move it from project to project very easily. Regarding styles and css I am not sure if it is actually the best idea. A lot of components might share styles so creating a 1-1 relationship between a css file and a module might result in repeated styling. On the other hand I love the idea of keeping everything that is required by a component in one unit. @maxwellito what do you think?

from generator-ghurt.

wallies avatar wallies commented on September 9, 2024

i like keeping styles and css as they are, much easier to share common styles and cuts down on duplicating which i think could happen if we went modular for css. I personally think we should move tests into the same folder as that makes logical sense to me. Did you also see the recommendations of naming files @lefos987?

from generator-ghurt.

maxwellito avatar maxwellito commented on September 9, 2024

Having the script and the test at the same place is not a bad idea. Because we always work with both when we code. I'm just a bit disappointed about the _test.js, I find .spec.js cleaner. I also don't want to put all the scripts in the app folder, let's keep our solution.
About the scripts, we need to split them to make a file for each type : directory, controller.. It's easier to do with a generator, I'm just scared it will make the repo messier.

from generator-ghurt.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.