Comments (6)
I just optimized code in clean.sh script and fixed a bug than can cause your issues, tell me if you can still reproduce them.
from mylittlelutrisscripts.
Hello, thank you for your report.
I can not reproduce your issue on my computer, I need Lutris log file to debug your issue.
Please follow steps from this page:
https://github.com/legluondunet/MyLittleLutrisScripts/blob/master/.github/ISSUE_TEMPLATE/report-issue.md
from mylittlelutrisscripts.
That was impressively fast, thank you!
The issue was probably caused by me installing to a different directory than the default, I didn't think that would matter.
Can I suggest changes to the script to support that (installing to any directory)?
To detect the game directory, you can find the StarCraft.exe and strip that out of the string:
gamedir="$PWD/`dirname $(find -name StarCraft.exe)`"
# Sets the variable gamedir to something like /home/audunmg/Games/starcraft/./drive_c/anything/Starcraft
Then to create the symbolic links you can strip off the drive_c/ prefix:
cd Program Files
ln -s "../${gamedir##*drive_c/}" "Starcraft"
This should make it easier to unpack the cnc-ddraw, since unzip -d "$gamedir" cnc-ddraw.zip
, and copying the starcraft.mpq, since you can specify absolute paths.
I'd be happy to make a pull request if that's ok?
Please let me know if I'm being too much. It's weekend after all.
Debug output showing script not finding where i installed the game:
7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21
p7zip Version 16.02 (locale=en_GB.UTF-8,Utf16=on,HugeFiles=on,64 bits,20 CPUs x64)
Scanning the drive for archives:
1 file, 2607157 bytes (2547 KiB)
Extracting archive: /home/audunmg/.cache/lutris/installer/starcraft/wrapper/cnc-ddraw.zip
--
Path = /home/audunmg/.cache/lutris/installer/starcraft/wrapper/cnc-ddraw.zip
Type = zip
Physical Size = 2607157
Everything is Ok
Folders: 7
Files: 18
Size: 5407019
Compressed: 2607157
lutris-wrapper: /home/audunmg/.cache/lutris/installer/starcraft/script/clean.sh
Started initial process 1942559 from /home/audunmg/.cache/lutris/installer/starcraft/script/clean.sh /mnt/img
Start monitoring process.
can not find Starcraft install
Monitored process exited.
Initial process has exited (return code: 0)
All processes have quit
Exit with return code 0
7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21
p7zip Version 16.02 (locale=en_GB.UTF-8,Utf16=on,HugeFiles=on,64 bits,20 CPUs x64)
Scanning the drive for archives:
1 file, 10592318 bytes (11 MiB)
Extracting archive: /home/audunmg/.cache/lutris/installer/starcraft/patch/SC-1161.7z
--
Path = /home/audunmg/.cache/lutris/installer/starcraft/patch/SC-1161.7z
Type = 7z
Physical Size = 10592318
Headers Size = 146
Method = LZMA2:12m BCJ
Solid = -
Blocks = 1
Everything is Ok
Size: 10696135
Compressed: 10592318
lutris-wrapper: /home/audunmg/.local/share/lutris/runners/wine/wine-ge-8-26-x86_64/bin/wine
Started initial process 1942571 from /home/audunmg/.local/share/lutris/runners/wine/wine-ge-8-26-x86_64/bin/wine /home/audunmg/.cache/lutris/installer/starcraft/SC-1161.exe
Start monitoring process.
fsync: up and running.
wine: RLIMIT_NICE is <= 20, unable to use setpriority safely
Initial process has exited (return code: 0)
wine: Read access denied for device L"\\??\\F:\\", FS volume label and serial are not available.
Monitored process exited.
Exit with return code 0
from mylittlelutrisscripts.
The issue was probably caused by me installing to a different directory than the default, I didn't think that would matter.
you broke an important Lutris script rule: always let the default options unchanged during install ;)
I thought your issues could be caused because you modified default game install directory, that's why I optimized and secured my code in clean.sh script:
- script exit if it doesn't find starcraft install directory and let a message error in Lutris log
But I fixed two other things too.
When we write Lutris script installer, we should prioritizing Lutris code usage and minimize bash code usage.
That why I will not complexify more my script code.
But you are welcome to help us to write Lutris game scripts.
If game installs correctly for you now, can we close this issue?
from mylittlelutrisscripts.
I tested and it works, feel free to close this.
Just a little question, about the comment the Program Files (x86)
directory, in all of my testing, the game installers chooses the default one from the wine (or windows) registry, and I haven't seen one which picks a different one, so it seems really strange to me.
Is there a starcraft cd version which doesn't pick this one, and this is to work around that?
from mylittlelutrisscripts.
Is there a starcraft cd version which doesn't pick this one, and this is to work around that?
yes, one Starcraft cd version installs his files to "program files" instead of "program files (x86)", so my script creates a symbolik link between this two folders.
from mylittlelutrisscripts.
Related Issues (20)
- Rune - no sound HOT 7
- Silent Hill EE HOT 3
- Genshin Impact for update 3.5 broken HOT 3
- Gameforge Client - Metin2 Language Issue HOT 6
- Update SeriousSamClassic-VK release link. HOT 1
- Warcraft 3 Frozen Throne cannot install because lack of certificate HOT 4
- Tomb Raider 1996 steam + Tomb1Main HOT 4
- Little scripts are not so little... HOT 1
- Starcraft.mpq file gets put in the Wrong Location HOT 1
- Jazz Jackrabbit 2 - Fullscreen widescreen support HOT 12
- Starcraft : ddraw dans le mauvais répertoire HOT 5
- Warcraft III installation stuck at black screen HOT 11
- Age of Empires - Unable to load libGLX_nvidia.so.0 HOT 7
- Wolfenstein 3D - All PC versions - ECWolf ; Outdated ECWolf HOT 14
- Splinter cell install fails when picking english HOT 2
- Game Won't Start - Silent Hill 2 EE HOT 3
- Theme Hospital (CorsixTH) Code 256 HOT 1
- Motoracer 2 HOT 4
- Tomb Raider 1 - glibc issue on Linux Mint 21.3? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mylittlelutrisscripts.