There is no way to prevent the subtitle from being drawn

[lemonuibylemon]

There is no way to prevent the subtitle from being drawn

[KimTisott]

@justalemon

I see four possible solutions:

1. Add a master SubtitleVisible property to control image, text and count rendering;
2. Render image, text and count separately - and text only if not empty;
3. Render image, text and count together, but only if all are set to valid values;
4. Expose SubtitleImage property to allow manual removal of the entire subtitle;

What would you suggest? I will submit a PR.

[justalemon]

What do you mean with subtitle? Because the subtitle is the white text on a black background.

[KimTisott]

What do you mean with subtitle?

The white text on a black background right under the title. In the image, 'Player' is not the subtitle, it's the first item of the menu. The subtitle background renders even when there is no subtitle nor item count.

This is how it's supposed to look when there is no subtitle.

[justalemon]

OH

I see it now.

In that case, to give more customization options, I would suggest an enum like SubtitleBehavior where it defines the behavior of the subtitle to 3 possible styles:

1. Always show the background even if is empty, which should be the default (AlwaysShow = 0)
2. Hide when there is no text, show when there is some (HideOnEmpty = 1)
3. Always hide the subtitle and it's background (AlwaysHide = 2)

[KimTisott]

This would conflict with the existing CountVisibility.

Maybe subtitle should be the entire line, which contains the Background, the Text and the Count properties? The count is already within the subtitle background anyways.

IMHO the way you're going with enums, it will get messy really fast with the multiple customizations. We could maybe try using one bit field enum to allow multiple configs, such as AutoCount, ShowText and HideBackground.

Looking at it now, might be better to have a separate Subtitle object, containing Background, Count and Text properties, and either a visibility config for each one, or a master bit field enum.

Either way, these changes imply in breaking changes, which I'm unsure how comfortable you are with. I could just create a PR with the changes I envision so you can review/modify them as you wish.

[justalemon]

I feel that it will complement CountVisibility to be honest.

With the Flag enums and Subtitle object, those would be a breaking changes which is not something I would like (NativeUI had some nasty breaking changes almost every single release before I helped with the most recent releases, and I wouldn't like to see that again).