Comments (9)
Well, actually this isn't a bug. The constructor of TestController
will always be called, indeed, you're doing it at [(new TestController), "page"]
, it is not something on the Siler internals... We can't prevent or predict user code inside a lib/framework.
from siler.
I agree it cannot be prevented, this is why I propose a workaround that will work with non-static methods without side effects
from siler.
Handling class construction isn't a Siler concern, at least for now, you should look for something like Pimple. Yet you could just wrap it in a Closure:
Route\get('user', function () {
$c = new TestController();
return $c->page();
});
from siler.
@leocavalcante this is actually a problem as the documentation says the router can use any callable. In this case it is a problem as it causes code execution that the user will be unaware of. I agree its not a problem with Siler per se, but this is the way this particular callable works. If Siler decides not to address this, this is fine, but the documentation needs to be updated to caveat this case.
I believe other routers have recognized this as a problem and have come up with a solution:
Example at:
https://github.com/magnus-eriksson/router
from siler.
@leocavalcante this is actually a problem as the documentation says the router can use any callable. In this case it is a problem as it causes code execution that the user will be unaware of. I agree its not a problem with Siler per se, but this is the way this particular callable works. If Siler decides not to address this, this is fine, but the documentation needs to be updated to caveat this case.
I believe other routers have recognized this as a problem and have come up with a solution:
Example at:
https://github.com/magnus-eriksson/router
from siler.
@leocavalcante this is actually a problem as the documentation says the router can use any callable. In this case it is a problem as it causes code execution that the user will be unaware of. I agree its not a problem with Siler per se, but this is the way this particular callable works. If Siler decides not to address this, this is fine, but the documentation needs to be updated to caveat this case.
I believe other routers have recognized this as a problem and have come up with a solution:
Example at:
https://github.com/magnus-eriksson/router
from siler.
@leocavalcante this is actually a problem as the documentation says the router can use any callable. In this case it is a problem as it causes code execution that the user will be unaware of. I agree its not a problem with Siler per se, but this is the way this particular callable works. If Siler decides not to address this, this is fine, but the documentation needs to be updated to caveat this case.
I believe other routers have recognized this as a problem and have come up with a solution:
Example at:
https://github.com/magnus-eriksson/router
from siler.
Sorry for reposting so many times. Github was showing 500 page and unable to post message.
from siler.
NP, I got some buggy behavior from Github too.
from siler.
Related Issues (20)
- Paginator object with GraphQL annotations HOT 1
- Deannotate interdependent types HOT 3
- Directive added to FIELD_DEFINITION is not being resolved HOT 1
- Route doesn't match with query string paramenters
- PHP 8 support HOT 2
- API returns 'Not Found' after first request on v1.7.9 HOT 2
- When using url encoded string in query parameters the route is not recognized ( "%3A") HOT 1
- Question about Swoole and Container for parallel requests HOT 2
- Call to undefined function Siler\Route\get()
- Question Siler Swoole
- Using Coroutines and swoole Hooks for MySQL PDO queries
- Error handler? HOT 1
- Add graphql curl example HOT 10
- Nested Routes?
- Built in config? HOT 5
- Adding a resolveType HOT 1
- How to throw an Exception in the resolver? HOT 1
- How to implement Interface and Union HOT 8
- GraphQL Annotation for Types Arguments HOT 4
- GraphQL type is declared but its not Identified as valid type HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from siler.