Comments (6)
Hi @leonardochaia, no worries. I have both tried Region.EntireTerminal
and Region.Scrolling
. When I find the time I can try to extract a simplified reproduction of the issue and raise an issue with the CommandLine.Rendering folks. I'll reference this issue to keep track. I agree that the code looks much cleaner this way.
from dotnet-affected.
All right, managed to reproduce it in this GitHub build.
The fix came from here
from dotnet-affected.
I did some further investigation and when I output straight to the IConsole it does work.
from dotnet-affected.
Hi @wterpstra ! I'm sorry I haven't been able to spend some time on this one.
I'm not really sure what's going on TBH but maybe changing the Region we provide here might have something to do with it?
I don't really know.
If we can determine it's an issue with CommandLine.Rendering then we should file an issue there.
We can definitively remove it for now if its giving us problems, however I think view-related the code looks much cleaner using it.
from dotnet-affected.
Hey @wterpstra! Just wanted you to know that I'm be building an Azure Pipelines where I'm using the current deployed version (1.0.0-preview-1
) of dotnet-affected
which works fine, since it is not using the ComandLine.Rendering
stuff.
I wanted to ask you if you can give me more info of the stuff you have tried, so that we don't duplicate effort.
I'm planning merging #5, figure out #1 and deploy a new preview release.
from dotnet-affected.
Hey @wterpstra, I've released v1.0.0-preview-3
which includes the fix.
I've tested in Azure DevOps and it seems to be working fine.
So perhaps with the --solution-path
and this fix you could give v1.0.0-preview-3
and report back? :)
Thanks for the help bud!
from dotnet-affected.
Related Issues (20)
- Add unit tests for GitChangesProvider HOT 1
- Make '--verbose' parameter more verbose HOT 4
- Add JSON formatter
- NullReference exception when running dotnet affected on a set of changes that adds the Directory.Packages.props file
- Add support for package version override in detecting changes in NuGet versions HOT 2
- Tool not working HOT 1
- Changes in Directory.Build.props not detected HOT 5
- split code to library and CLI HOT 10
- Incorrect evaluation of 'Directory.Packages.props' HOT 7
- Update System.CommandLine
- Error: Couldn't find Git Commit or Branch with name HOT 6
- Text file contains duplicated projects
- Finding affected projects take longer then expected HOT 2
- Dotnet 7 partial support HOT 24
- How to build/deploy monorepo with several APIs where each API has smoke test and DB migration projects HOT 5
- Version 3.1.0 does not work on Alpine Linux HOT 2
- Add format options to README.md and --help HOT 4
- Ability to exclude projects HOT 1
- Ability to distinguish between changed and affected projects HOT 8
- Deleted file does not affect project HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dotnet-affected.