Giter Site home page Giter Site logo

Comments (6)

wterpstra avatar wterpstra commented on May 19, 2024 1

Hi @leonardochaia, no worries. I have both tried Region.EntireTerminal and Region.Scrolling. When I find the time I can try to extract a simplified reproduction of the issue and raise an issue with the CommandLine.Rendering folks. I'll reference this issue to keep track. I agree that the code looks much cleaner this way.

from dotnet-affected.

leonardochaia avatar leonardochaia commented on May 19, 2024 1

All right, managed to reproduce it in this GitHub build.

The fix came from here

from dotnet-affected.

wterpstra avatar wterpstra commented on May 19, 2024

I did some further investigation and when I output straight to the IConsole it does work.

from dotnet-affected.

leonardochaia avatar leonardochaia commented on May 19, 2024

Hi @wterpstra ! I'm sorry I haven't been able to spend some time on this one.

screen.Render(Region.EntireTerminal);

I'm not really sure what's going on TBH but maybe changing the Region we provide here might have something to do with it?
I don't really know.

If we can determine it's an issue with CommandLine.Rendering then we should file an issue there.
We can definitively remove it for now if its giving us problems, however I think view-related the code looks much cleaner using it.

from dotnet-affected.

leonardochaia avatar leonardochaia commented on May 19, 2024

Hey @wterpstra! Just wanted you to know that I'm be building an Azure Pipelines where I'm using the current deployed version (1.0.0-preview-1) of dotnet-affected which works fine, since it is not using the ComandLine.Rendering stuff.

I wanted to ask you if you can give me more info of the stuff you have tried, so that we don't duplicate effort.
I'm planning merging #5, figure out #1 and deploy a new preview release.

from dotnet-affected.

leonardochaia avatar leonardochaia commented on May 19, 2024

Hey @wterpstra, I've released v1.0.0-preview-3 which includes the fix.

I've tested in Azure DevOps and it seems to be working fine.

So perhaps with the --solution-path and this fix you could give v1.0.0-preview-3 and report back? :)

Thanks for the help bud!

from dotnet-affected.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.