Comments (13)
Cheers - can just update this one - seems like these issues don't occur when using the device simulator in Google Chrome, and are fine on Firefox on my Pixel as wel - will procure an actual iOS device to test on and let you know π
from loconotion.
Yup, I'm aware, haven't done any in-depth investigation since I do enough obscure-bugs-on-ios-only-troubleshooting during my regular job π Hopefully the new year will bring some discipline to actually look into this...
from loconotion.
Hi all, check out f9a1dc4, should have fixed this - I've also update the test site at https://loconotion-example.netlify.app/
from loconotion.
Thanks for opening the issue - I can see this too. Ideally horizontal scroll should be available only on long, non-wrappable items (like tables), and all text content should fit the page width. Will take a look π
from loconotion.
Should be fixed as of c1329e0 - the example page at https://loconotion-example.netlify.app/ has been updated as well π
from loconotion.
Thanks for this!
I played around this for a bit, and the horizontal scroll problem seems to have been fixed!
I did notice a couple more things, and I will let you decide if you if want to see a separate issue for this or not.
- https://loconotion-example.netlify.app/portal.html seems to render the attributes of the page funny on iOS (both in portrait or landscape)
- I can't seem to click on any of the links on iOS on this page βΒ https://loconotion-example.netlify.app/books-table.html
Again, thank you for this! Let me know if you need separate issues for these (then please let me know and close this issue) or you could just use this one.
from loconotion.
Hello, just FYI I tried this on a iPad mini not so long ago and it seems to still be an issue - will require further investigation - any help with this is welcome π
from loconotion.
I donβt know if itβs the right place to post this but this page is mangled in Chrome iOS
from loconotion.
@vzakharov, seems like a bug on WebKit (Chrome on iOS is almost Safari because of iOS limitations). Have the same issue on desktop Safari, don't know the way to fix it.
@leoncvlt are you aware of this?
from loconotion.
@leoncvlt, the problem with the empty spaces inside the blocks happens because Safari does not calculate height as Chrome does.
If you manually edit the generated HTML, the problem will be solved:
- to
$('#notion-app > div > div > div > div.notion-scroller.vertical.horizontal > div:nth-child(2)')
setmax-height: 50px;
- to
$('#notion-app > div > div > div > div.notion-scroller.vertical.horizontal > div:nth-child(2) > div > div > div > div > div:nth-child(2)')
removeheight
Not the best solution and I don't know how to insert such logic inside the code with ChromeDriver. Still, the issue is important for me, because I don't want to miss iOS users on my Notion-generated websites.
from loconotion.
@leoncvlt, the problem with the empty spaces inside the blocks happens because Safari does not calculate height as Chrome does.
If you manually edit the generated HTML, the problem will be solved:
- to
$('#notion-app > div > div > div > div.notion-scroller.vertical.horizontal > div:nth-child(2)')
setmax-height: 50px;
- to
$('#notion-app > div > div > div > div.notion-scroller.vertical.horizontal > div:nth-child(2) > div > div > div > div > div:nth-child(2)')
removeheight
Not the best solution and I don't know how to insert such logic inside the code with ChromeDriver. Still, the issue is important for me, because I don't want to miss iOS users on my Notion-generated websites.
Where and how did you insert this code to make it work? The hashed css file?
from loconotion.
@leoncvlt I'd like to help with this. Did you come up with anything on this? I'm guessing we'll need to inject some code at the scraper level?
from loconotion.
Will close now, feel free to make some noise if you get any more issues about this.
from loconotion.
Related Issues (20)
- Does not download files HOT 1
- `--dark-theme` argument has no effect HOT 4
- Docker container not building HOT 9
- Discord server for devs HOT 2
- CI/CD deployment to github pages HOT 4
- Exported Table Row out of proportion HOT 1
- Question: Working on exported html files directly, instead of scraping HOT 1
- Foldable titles do not work on exported pages
- How to remove connect facebook.net and other site trackers HOT 2
- Loconotion timing out due to weird "notion-unknown-block" div HOT 2
- flag emojis are not showing on win HOT 1
- Alternative project repo HOT 16
- Issue with sample page HOT 2
- [Bug] Code snippet rendering is incorrect
- Docker build loconotion failed. HOT 11
- can't run it HOT 2
- Anchor links are not working
- KeyError: 'style' HOT 2
- Bad html output structure HOT 2
- Docker file needs to be updated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from loconotion.