Giter Site home page Giter Site logo

Comments (13)

leoncvlt avatar leoncvlt commented on May 21, 2024 3

Cheers - can just update this one - seems like these issues don't occur when using the device simulator in Google Chrome, and are fine on Firefox on my Pixel as wel - will procure an actual iOS device to test on and let you know πŸ™‚

from loconotion.

leoncvlt avatar leoncvlt commented on May 21, 2024 2

Yup, I'm aware, haven't done any in-depth investigation since I do enough obscure-bugs-on-ios-only-troubleshooting during my regular job πŸ™ˆ Hopefully the new year will bring some discipline to actually look into this...

from loconotion.

leoncvlt avatar leoncvlt commented on May 21, 2024 2

Hi all, check out f9a1dc4, should have fixed this - I've also update the test site at https://loconotion-example.netlify.app/

from loconotion.

leoncvlt avatar leoncvlt commented on May 21, 2024 1

Thanks for opening the issue - I can see this too. Ideally horizontal scroll should be available only on long, non-wrappable items (like tables), and all text content should fit the page width. Will take a look πŸ˜ƒ

from loconotion.

leoncvlt avatar leoncvlt commented on May 21, 2024 1

Should be fixed as of c1329e0 - the example page at https://loconotion-example.netlify.app/ has been updated as well πŸ™‚

from loconotion.

looselytyped avatar looselytyped commented on May 21, 2024

Thanks for this!

I played around this for a bit, and the horizontal scroll problem seems to have been fixed!

I did notice a couple more things, and I will let you decide if you if want to see a separate issue for this or not.

Again, thank you for this! Let me know if you need separate issues for these (then please let me know and close this issue) or you could just use this one.

from loconotion.

leoncvlt avatar leoncvlt commented on May 21, 2024

Hello, just FYI I tried this on a iPad mini not so long ago and it seems to still be an issue - will require further investigation - any help with this is welcome πŸ˜ƒ

from loconotion.

vzakharov avatar vzakharov commented on May 21, 2024

I don’t know if it’s the right place to post this but this page is mangled in Chrome iOS
8B61115B-5C42-4879-A3E6-72A380DDB0F9

from loconotion.

tiulpin avatar tiulpin commented on May 21, 2024

@vzakharov, seems like a bug on WebKit (Chrome on iOS is almost Safari because of iOS limitations). Have the same issue on desktop Safari, don't know the way to fix it.
telegram-cloud-photo-size-2-5442923930538063178-y

@leoncvlt are you aware of this?

from loconotion.

tiulpin avatar tiulpin commented on May 21, 2024

@leoncvlt, the problem with the empty spaces inside the blocks happens because Safari does not calculate height as Chrome does.

If you manually edit the generated HTML, the problem will be solved:

  • to $('#notion-app > div > div > div > div.notion-scroller.vertical.horizontal > div:nth-child(2)') set max-height: 50px;
  • to $('#notion-app > div > div > div > div.notion-scroller.vertical.horizontal > div:nth-child(2) > div > div > div > div > div:nth-child(2)') remove height

Not the best solution and I don't know how to insert such logic inside the code with ChromeDriver. Still, the issue is important for me, because I don't want to miss iOS users on my Notion-generated websites.

from loconotion.

mabdullahabid avatar mabdullahabid commented on May 21, 2024

@leoncvlt, the problem with the empty spaces inside the blocks happens because Safari does not calculate height as Chrome does.

If you manually edit the generated HTML, the problem will be solved:

  • to $('#notion-app > div > div > div > div.notion-scroller.vertical.horizontal > div:nth-child(2)') set max-height: 50px;
  • to $('#notion-app > div > div > div > div.notion-scroller.vertical.horizontal > div:nth-child(2) > div > div > div > div > div:nth-child(2)') remove height

Not the best solution and I don't know how to insert such logic inside the code with ChromeDriver. Still, the issue is important for me, because I don't want to miss iOS users on my Notion-generated websites.

Where and how did you insert this code to make it work? The hashed css file?

from loconotion.

mabdullahabid avatar mabdullahabid commented on May 21, 2024

@leoncvlt I'd like to help with this. Did you come up with anything on this? I'm guessing we'll need to inject some code at the scraper level?

from loconotion.

leoncvlt avatar leoncvlt commented on May 21, 2024

Will close now, feel free to make some noise if you get any more issues about this.

from loconotion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.