Giter Site home page Giter Site logo

Comments (5)

leshchenko1979 avatar leshchenko1979 commented on May 22, 2024 1

@jiatern , here you go

from loconotion.

leshchenko1979 avatar leshchenko1979 commented on May 22, 2024

It turned out that the lists on the original Notion site contain instructions like --pseudoBefore--content: "1.", and a css file from the original Notion site has the following code:


/* ==================================================================== */
/* Customizable class utilities.
 * see shared/cssHelpers.ts
 *
 * Use css variables to customize styles for pesudoselectors we
 * can't easily target from inline style properties.
 *
 * Each class defined below should be added to customizableClassnameHelpers.ts.
 * For each CSS property, use var(`--${className}--${propertyName}`) as the value.
 *
 * We use camelCase names here so they're easier to write in Typescript.
 * TODO: use something like linaria to automate this shenanigans.
/* ==================================================================== */

.pseudoAfter:after {
  color: var(--pseudoAfter--color);
  content: var(--pseudoAfter--content);
  border: var(--pseudoAfter--border);
  width: var(--pseudoAfter--width);
  height: var(--pseudoAfter--height);
  display: var(--pseudoAfter--display);
  background: var(--pseudoAfter--background);
}

.pseudoBefore:before {
  color: var(--pseudoBefore--color);
  content: var(--pseudoBefore--content);
  border: var(--pseudoBefore--border);
  width: var(--pseudoBefore--width);
  height: var(--pseudoBefore--height);
  display: var(--pseudoBefore--display) !important;
  background: var(--pseudoBefore--background);
}

.pseudoSelection ::selection {
  color: var(--pseudoSelection--color);
  background: var(--pseudoSelection--background);
  text-shadow: var(--pseudoSelection--textShadow);
}

After I inserted this code into one of my local css files, the bullets and list item numbers started displaying properly.

So, I wonder what a permanent fix for this would look like. It seems like loconotion might be deleting too much of the original notion code? @leoncvlt

from loconotion.

leoncvlt avatar leoncvlt commented on May 22, 2024

Curious, it shouldn't be stripping any css. Thanks for the heads up, I'll have some time to look at this this weekend 😃

from loconotion.

jiatern avatar jiatern commented on May 22, 2024

Facing the same issue here. I am not well versed with html/css but apparently I replaced the html file with an older version that was parsed few weeks ago (without changing the CSS file), the bullets appeared.

Not sure if it helps but I've attached both here.
html.zip

from loconotion.

leshchenko1979 avatar leshchenko1979 commented on May 22, 2024

Facing the same issue here. I am not well versed with html/css but apparently I replaced the html file with an older version that was parsed few weeks ago (without changing the CSS file), the bullets appeared.

Not sure if it helps but I've attached both here.

html.zip

Obviously, the fix you described prevents you from updating your site.

You can insert the code above into your loconotion.css and it should fix the problem after your run the scan once again.

I will be adding a PR about this a bit later today, I hope @leoncvlt Leonardo will have time to look it through :)

from loconotion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.