Giter Site home page Giter Site logo

Comments (4)

let-def avatar let-def commented on August 24, 2024

Thanks for the bug report (and cheers to 2024! :) ).

This is indeed a regression. I thought I had handled that case but it was subtler than I expected...

Long story short: when initiating a reduction there is a special case (a "limit condition") because we don't know anything about the state of the stack yet, so we have to peek at the first state, which is not part of the reduction but allow us to identify the possible reductions coming next. And the code was not handling this case correctly, because it forgot to "unconsume" this first state (the corresponding expression would have been something like OPAREN ; [OPAREN; chars], which is completely incorrect but is what the code was trying to match when chars is empty).
Yet another form of off-by-one :).

And looking at it again, I got an idea that might make it possible to get rid of this special case, I will experiment...

from lrgrep.

let-def avatar let-def commented on August 24, 2024

And thanks for the tiny example, I will keep it in the code base it is very convenient for experimenting.

from lrgrep.

let-def avatar let-def commented on August 24, 2024

I think I found a way to simplify this case, the current master has a more uniform treatment of reductions.

from lrgrep.

SquidDev avatar SquidDev commented on August 24, 2024

Thank you so much - just tried out current master and it works perfectly! Really liking the new syntax, I've managed to get rid of all my hacks, and there's some rules which are significantly cleaner now.

Happy new year to you too! :)

from lrgrep.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.