Giter Site home page Giter Site logo

Routes not saving about dungeontools HOT 8 OPEN

letstimeit avatar letstimeit commented on May 20, 2024
Routes not saving

from dungeontools.

Comments (8)

srenauld avatar srenauld commented on May 20, 2024 3

There isn't one. There's a plan to donate all the proceeds from curseforge (when we're on it) to charity, while keeping a very small share for under-the-weather issues. How & which charity is still TBD, but the idea is on the table - and obviously, since we're not on curseforge yet, it's still only an idea.

All of the people currently involved think this should be a community add-on, community-run and community-maintained, and not a case where a single person gets all the burden. We're hopefully going to be moving in that direction, which also means more than one main contributor 🥳

from dungeontools.

srenauld avatar srenauld commented on May 20, 2024

Hey!

We've had somebody flag up this issue on an old version ( #35). Can you grab 1.1.6 from the releases (here: https://github.com/LetsTimeIt/DungeonTools/releases/tag/v1.1.6), or update through wowup, and let me know if it still doesn't work?

from dungeontools.

arenstam avatar arenstam commented on May 20, 2024

Hi,

I was having the same issue, i think i know how to duplicate it. If you create a route replacing the 'default' route and then log off/close the game, it will be replaced with a blank empty route.

If you create new route via 'new' and then create your route, it wont be reset after a relog/exit game.

from dungeontools.

srenauld avatar srenauld commented on May 20, 2024

@arenstam Your comment really helped. Was able to track down the feature that's causing this:

https://github.com/LetsTimeIt/DungeonTools/blob/main/DungeonTools.lua#L154

            do
            for _,presets in pairs(db.presets) do
                for presetIdx,preset in pairs(presets) do
                    if presetIdx == 1 then
                        if preset.text ~= "Default" then
                            preset.text = "Default"
                            preset.value = {}
                        end
                    end
                end
            end
            for k,v in pairs(db.currentPreset) do
                if v <= 0 then db.currentPreset[k] = 1 end
            end
        end

This happens on initialization; if the preset is the first in the list, and it is not called Default, then it gets reset to Default and emptied.

from dungeontools.

srenauld avatar srenauld commented on May 20, 2024

Just confirmed it ingame; that's where and how it happens: the user needs to rename the default route for it to trigger.

I'm going to scrap that right now, and when we overhaul the route container (there's so many things wrong with how routes are stored, serialized and handled. To give you an idea, I have no choice but to break a bunch of people's HoA routes because I'm about to unlink two mobs), I will bring a "Reset to default" when we add sensible defaults.

Thank you very much for the report, and @arenstam for the additional pointers leading to this 👍

from dungeontools.

Path98912 avatar Path98912 commented on May 20, 2024

Awesome thanks I downloaded the issues and as long as I name my route it saves perfectly. Thanks again.

One last question and I hope this isn't cross pollinating the issues. How do I update the add on via wowup, it isn't showing in my add on list.

from dungeontools.

srenauld avatar srenauld commented on May 20, 2024

Add this repository on it! I described it to somebody else here and I have on my list of things to do for today to write documentation regarding that and a lot of other things, as these questions come up a lot.

Essentially, you go to "Get Addons", click "Install from URL", then fill in this repo's URL (https://github.com/LetsTimeIt/DungeonTools), and Wowup then tracks releases on the repo automatically.

from dungeontools.

Path98912 avatar Path98912 commented on May 20, 2024

Awesome, I lied, last questions. What's the patreon or whatever to kick some donations to you all for doing the lords work here?

from dungeontools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.