Comments (5)
juliangruber
commented on May 23, 2024
can you explain why this is a breaking change? it was never documented what an empty string "" as location would do and so this is a fix as it prevents unexpected behavior.
from abstract-leveldown.
juliangruber
commented on May 23, 2024
ah i guess if location doesn't matter, like when using memdown, people like to pass an empty string?
from abstract-leveldown.
juliangruber
commented on May 23, 2024
memdown does that for example: https://github.com/Level/memdown/blob/master/memdown.js#L124
from abstract-leveldown.
juliangruber
commented on May 23, 2024
i reverted and published 2.2.2, sorry for the trouble. i'm opening a new issue for a better strategy.
from abstract-leveldown.
willwhite
commented on May 23, 2024
Thanks!
from abstract-leveldown.
Related Issues (20)
- Open Test - Regular expression is too strict. HOT 2
- Drop IE10
- Update changelog for v6
- Question: the proper way to pass some specific tests. HOT 7
- Reorder v6 upgrade guide
- Range tests on zero-length buffer+string are incompatible with bytewise, charwise & IDB HOT 2
- Enable abstract-leveldown stores to emit events for levelup HOT 13
- An in-range update of tape is breaking the build 🚨 HOT 1
- Release 6.0.2
- An in-range update of level-concat-iterator is breaking the build 🚨 HOT 3
- Return early and call back asynchronously if batch is empty
- Expose prev() ? HOT 1
- An in-range update of airtap is breaking the build 🚨 HOT 3
- Flag to disable iterator tests HOT 19
- Document which abstract methods must/should be implemented
- Invalid Reverse Iterator Seek Test HOT 7
- Expand binary key tests HOT 1
- Open to adding an optional "batched get" capability? HOT 5
- API design: `getMany()`, key & value iterators, `iterator.nextv()` HOT 3
- Check likely false positive vulnerabilities in devDependencies HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abstract-leveldown.