Support redirects

[lexs]

Support redirects

[lexs]

We do follow redirects but the problem here is that the redirect is from http to https. Here is a StackOverflow post (and Java bug) about this http://stackoverflow.com/a/1884427/253583.

If you change the original url to use https it works for example. Do you think we should manually handle redirects from http to https anyways?

[orrc]

I'm trying to use redirects (from HTTP to HTTP) and they're not working, and I can't see in the code anywhere where redirects are considered. I get the same stacktrace above, and I can see that no second network is being sent.

I call HttpURLConnection.setFollowRedirects(true); before attempting to load any images.

The only slightly different thing is that the server I'm using is returning HTTP 307 redirects (rather than the more oft-used 301 or 302).

What have I missed? :)

[orrc]

The answer seems to be the HTTP 307 status code.
http://b.android.com/41739 indicates that the 307 status code isn't properly handled.

I tested this library with the Twitter API URL above (though went from HTTPS to HTTPS) and it worked great.

[lexs]

The library relies on HttpUrlConnection to handle redirects (which it does by default).

I don't think this it's possible to work around this issue as-is, however I could modify ConnectionHandler to allow for returning a new UrlConnection so you could work around this. Do you want this?

https://github.com/lexs/webimageloader/blob/master/webimageloader/src/main/java/com/webimageloader/ConnectionHandler.java

[orrc]

Yeah, that sounds good.

I've been thinking about integrating OkHttp anyway, since it fixes some other Android HTTP bugs that I need to deal with. So this would probably work out.

[lexs]

I wonder if it would be better to actually change the signature to take an URL so your free to use OkHttp if you want instead of having to just throw a connection away? It would still only be called for http(s) though.

[orrc]

Sounds like a good idea to me!

[mecid]

is this issue fixed in latest maven build?

[orrc]

@mecid Which issue specifically? Redirects already work fine with this library; 307 redirects don't work, but that's an Android bug (which I solved by using pull request #17 and OkHttp).

[mecid]

@orrc this your pull request included in latest maven build?

[orrc]

@mecid No, the pull request is open; there hasn't been any discussion about it so far. I compiled my own JAR from source.

[lexs]

It's not merged yet, in the meantime you can clone @orrc repo and compile it yourself.

[mecid]

I am using okhttp from your sample, but redirects not working.