Giter Site home page Giter Site logo

Comments (6)

crosstyan avatar crosstyan commented on September 25, 2024 2

Seems perfect to me. Problem fixed!

from komorebi.

LGUG2Z avatar LGUG2Z commented on September 25, 2024

Thank you for this detailed report! I have just spent some time trying to reproduce this issue but I have not been successful.

Could you please share the komorebi.ahk you are using and also your Windows version (Get-ComputerInfo | select WindowsProductName, WindowsVersion, OsHardwareAbstractionLayer)?

From the logs, I have traced down the Access is denied error to here, which is called when trying to focus the special Desktop Window when a workspace is empty. I have pushed a branch that addresses this error; it would be great if you could try that and see if it changes the behaviour you are experiencing.

from komorebi.

LGUG2Z avatar LGUG2Z commented on September 25, 2024

I think I found the panic 🎉

Message:  attempt to divide by zero
Location: komorebi-core\src\layout.rs:144

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 9 frames hidden ⋮
  10: core::panicking::panic<unknown>
      at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633\/library\core\src\panicking.rs:50
  11: komorebi_core::layout::Layout::calculate::ha406458b4d9a304c
      at <unknown source file>:<unknown line>
  12: komorebi::workspace::Workspace::update::h65bf8870d2c92ead
      at <unknown source file>:<unknown line>
  13: komorebi::window_manager::WindowManager::init::h07c7d42875dc4c52
      at <unknown source file>:<unknown line>
  14: komorebi::window_manager::WindowManager::restore_all_windows::h6966c89d55a8aaff
      at <unknown source file>:<unknown line>
  15: tracing_core::event::Event::metadata::h548cc0816da38c47
      at <unknown source file>:<unknown line>
  16: komorebi::process_command::<impl komorebi::window_manager::WindowManager>::read_commands::h9a03c573b27a0fe7
      at <unknown source file>:<unknown line>
  17: std::sys_common::backtrace::__rust_begin_short_backtrace::h225ab8fda49906c4
      at <unknown source file>:<unknown line>
  18: <&T as core::fmt::Debug>::fmt::hf247fbb9ac06d8b6
      at <unknown source file>:<unknown line>
  19: alloc::boxed::{{impl}}::call_once<unknown>
      at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633\library\alloc\src\boxed.rs:1575
  20: alloc::boxed::{{impl}}::call_once<unknown>
      at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633\library\alloc\src\boxed.rs:1575
  21: std::sys::windows::thread::{{impl}}::new::thread_start<unknown>
      at /rustc/a178d0322ce20e33eac124758e837cbd80a6f633\/library\std\src\sys\windows\thread.rs:56
  22: BaseThreadInitThunk<unknown>
      at <unknown source file>:<unknown line>
  23: RtlUserThreadStart<unknown>
      at <unknown source file>:<unknown line>

@crosstyan Don't worry about trying out that branch that I linked, it won't do anything for this issue. I will work on a separate fix for this.

from komorebi.

crosstyan avatar crosstyan commented on September 25, 2024

My output from Get-ComputerInfo | select WindowsProductName, WindowsVersion, OsHardwareAbstractionLayer

WindowsProductName WindowsVersion OsHardwareAbstractionLayer
------------------ -------------- --------------------------
Windows 10 Pro     2009           10.0.22000.1

the ahk file is the same as this sample.

By the way, I'm using a desktop organize software called fences, which I think is related to the problem.

Thank you again for helping solve this problem.

from komorebi.

crosstyan avatar crosstyan commented on September 25, 2024

I confirmed that Stardock Fences caused that problem. When I disable Fences, everything runs smoothly.

I have to admit compatibility is tricky to deal with, but maybe it's still worth investigating what caused that incompatibility.

Update: the problem is still existing, but I can switch to an empty workspace and switch back now, but moving to a workspace still cause the problem. (still using the old commit)

from komorebi.

LGUG2Z avatar LGUG2Z commented on September 25, 2024

@crosstyan I believe this bug should now be fixed with this commit: a53b2cc

Please pull the latest commit on master (which also now includes panic messages in the logs!) and try it out. I hope it fixes the issue for you 🤞 .

from komorebi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.