Issue with row detection

[liabru]

Issue with row detection

[liabru]

It looks like the reason is that the row detection isn't working correctly when the elements are hidden.

E.g. if the menu is visible before you apply:

$('.dropdown-menu').css('display', 'block');
$(".yamm .thumbnail").matchHeight();

It seems to work.
So there does seem to be a problem with the code for handling hidden elements.

I'll look at fixing this, before then you have two options:

• update matchHeight on the "browse" button click event, just before the menu shows (use the _update method)
• apply matchHeight before hiding the menu on page load

Hope that helps.

[rtpHarry]

Thanks for the feedback. Just wanted to check in and say based on your advice I did get it working satisfactorily. Because this was being used inside a Bootstrap 3 navbar I hooked into the opening event and updated it like this:

    $('.yamm .dropdown').on("show.bs.dropdown", function() {    
        $.fn.matchHeight._update();     
    })

[liabru]

Great!

I've got a fix for this nearly ready to go, so when I get time I'll push it and update this thread.

[liabru]

I've just pushed a fix for this in the latest master version.

If you have time it would be cool if you could try it (disable your previous fix temporarily first).

[rtpHarry]

Hey I tried out your new build and it has resolved the issue that I was seeing. Good work!

http://jsfiddle.net/rtpHarry/6mudcbuc/14/embedded/result/

(notice the _update() is disabled now on line 26 of the js)

[liabru]

Great, thanks for logging this!