Comments (3)
We should have a @nullable annotation here:
https://github.com/liato/android-bankdroid/blob/master/bankdroid-legacy/src/main/java/com/liato/bankdroid/banking/banks/americanexpress/model/AccountActivity.java#L11
And we should fix nullness issues as indicated by Android Studio's excellent Constant conditions and exceptions warning.
from android-bankdroid.
In this case I prefer to never return null when the return type is a collection. Instead I prefer to return an empty collection. That will remove the need of a null check everywhere where it is used. But I agree with you that we should start using the static code analysis which are available in Android Studio!
from android-bankdroid.
Yes, fixing the getter to never return null
is probably nicer in this particular case.
Android Studio has an excellent set of warnings, but unfortunately I don't know how to run them on CI.
from android-bankdroid.
Related Issues (20)
- Remove IcaBanken since they now require Mobilt BankID
- Meaning of "legacy" HOT 1
- Make crashlytics optional HOT 8
- Automate google play upload
- Cleanup banks that now required MobiltBankId
- SSL issue when connecting to Avanza HOT 5
- Bump minimum supported sdk to 14
- Update pinned certificate for api.ica.se HOT 1
- Notification on failed sync
- Dialog disappears on device rotation
- Time Picker changes state on device rotation
- Scrollable View changes position on Device Rotation
- Rikskortet wont update
- Ica banken certificate issue
- OKQ8 Server Certificate is not trusted for nettbank.edb.com
- java.lang.IllegalArgumentException: Illegal character in query
- Kan ni släppa en uppdaterad och säkrare version av Bankdroid?
- Could you release a updated more secure version of Bankdroid
- Suggest archiving this repo HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-bankdroid.