Panic on parameterized queries

[lib]

Panic on parameterized queries

[nikoudel]

Ok, found it :) No question signs allowed.

FAILS: rows, err := db.Query("select * from customer where id = ?", 1)
WORKS: rows, err := db.Query("select * from customer where id = ($1)", 1)

[taylortrimble]

Would anyone care to enlighten me on why the question mark fails? ? is used in the http://golang.org/pkg/database/sql examples, and I didn't see the other syntax until here!

[msakrejda]

We probably shouldn't panic (and/or document the parameter markers), but I don't see any standard parameter markers documented in the database/sql package--are there such? I know JDBC has them but some other DB APIs don't, and doing anything other than what Postgres natively supports (the dollar-prefixed ordinals) is rather hard to do correctly, as it involves parsing the query string in the driver.

[kisielk]

The parameter markers in database/sql are driver-specific, so yes, the query would need to be parsed and re-written by the driver. That seems error-prone.

[taylortrimble]

Absolutely we wouldn't translate requests! Original post was on my first day of SQL, so I just hadn't realized that parameter substitution was specific to the driver. Thanks! 💟