Giter Site home page Giter Site logo

Handle malloc errors properly about libass HOT 5 OPEN

libass avatar libass commented on May 27, 2024
Handle malloc errors properly

from libass.

Comments (5)

 avatar commented on May 27, 2024

Yeah, I also planned to do something about that. But for now it seems to be better to wait until all the other changes make it in.

from libass.

 avatar commented on May 27, 2024

If we do this, we should also treat integer overflows correctly.

E.g. I see stuff like: realloc(track->events, sizeof(ASS_Event) * track->max_events)

If the multiplication overflows, the allocation will be smaller than expected (but still "succeed"), and you'll have a problem.

from libass.

rcombs avatar rcombs commented on May 27, 2024

Yup.

from libass.

 avatar commented on May 27, 2024

Reminder that we really should do this (tm).

from libass.

 avatar commented on May 27, 2024

OK, here's a suggestion:

  • replace all malloc() calls with a ass_xmalloc() macro, which abort()s on malloc failure
  • code that actually checks for the malloc() result can still use malloc() proper
  • run a fuzz tests that make malloc() return NULL randomly to verify that the malloc checks actually work
  • add some helper macros to allocate arrays with avoiding integer overflows

from libass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.