Giter Site home page Giter Site logo

Comments (5)

thomaseizinger avatar thomaseizinger commented on May 30, 2024 1

Ah I think I know what is happening here. It is because libp2p-webrtc-websys is not exported from libp2p, we didn't bump its version in the latest release and thus we simply need a version bump here for this to work :)

Can you send a PR where you bump it to 0.3.0-alpha? We can then release it from there and it should work!

from rust-libp2p.

thomaseizinger avatar thomaseizinger commented on May 30, 2024 1

We should probably start thinking about what it needs to get out of alpha state and just re-export it from libp2p.

from rust-libp2p.

DougAnderson444 avatar DougAnderson444 commented on May 30, 2024

Is it possible this is due to the version discrepancy between libp2p-webrtc-websys and ../../libp2p_core?

crate depends on libp2p-core
crates.io libp2p-webrtc v0.6.0-alpha v0.40.1
../libp2p/ v0.53.1 v0.41.1

from rust-libp2p.

DougAnderson444 avatar DougAnderson444 commented on May 30, 2024

Ok I can do the version bump PR. Actually I realized that the issue is actually on libp2p-webrtc so I can include both in the PR at the same time.

What is the rationale behind not exporting it from libp2p if it is alpha? Would that really cause problems?

from rust-libp2p.

DougAnderson444 avatar DougAnderson444 commented on May 30, 2024

I can confirm the only way I can get the crates to compile is by using the git source instead of crates.io

libp2p = { git = "https://github.com/libp2p/rust-libp2p.git", features = [ "ed25519", "macros", "ping", "tokio"] }
libp2p-webrtc = { git = "https://github.com/libp2p/rust-libp2p.git", features = ["tokio"] }

from rust-libp2p.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.