asn message with choice and tag is not encoded correctly

[librasn]

asn message with choice and tag is not encoded correctly

[XAMPPRocky]

Thank you for your issue! I've now addressed this on main.

[yaozongyou]

@XAMPPRocky I think there is still some mistakes.

use rasn::AsnType;
use rasn::Decode;
use rasn::Encode;
use std::error::Error;

#[derive(Debug, AsnType, Decode, Encode)]
struct Message {
    id: i32,
    #[rasn(choice)]
    body: BODY,
}

#[derive(Debug, AsnType, Decode, Encode)]
#[rasn(choice)]
enum BODY {
    #[rasn(tag(context, 3000))]
    Request(Request),

    #[rasn(tag(context, 3001))]
    Response(Response),
}

#[derive(Debug, AsnType, Decode, Encode)]
struct Request {
    num: i32,
}

#[derive(Debug, AsnType, Decode, Encode)]
struct Response {
    ret: i32,
}

fn main() -> Result<(), Box<dyn Error>> {
    let p = Message {
        id: 1,
        body: BODY::Request(Request { num: 1 }),
    };
    let e = rasn::der::encode(&p).unwrap();
    println!("e: {:#04x?}", e);
    Ok(())
}

the above code prints 0x30,0x0a,0x02,0x01,0x01,0xbf,0xb8,0x17,0x03,0x02,0x01,0x01

but it should prints0x30,0x0a,0x02,0x01,0x01,0xbf,0x97,0x38,0x03,0x02,0x01,0x01

[XAMPPRocky]

@yaozongyou The mistake is in your code. You need to have #[rasn(automatic_tags)] above each item, if you want to apply that transformation, just like you have to write AUTOMATIC TAGS in the module. You can see in tests/issue35.rs for a correct example.

[yaozongyou]

@XAMPPRocky I have added #[rasn(automatic_tags)] as in tests/issue35.rs, but the output is 0xb8,0x17 which is not i wanted.
0xb8,0x17 as in binary is 1011100000010111 which is high-tag-nubmer form of 7191. the output should be 0x97,0x38 which in binary is 1001011100111000 which is high-tag-number form of 3000, and this is right.

by the way, i have changed the tag of Request from 100 to 3000.

[XAMPPRocky]

Thank you for updating it, I've now fixed that issue as well.

[yaozongyou]

thanks, it works as expected.