Comments (17)
The document name in my case is document
😅
Low creativity for a decent name.
libresign/tests/integration/features/sign/request.feature
Lines 192 to 195 in 831d7e9
Only a curiosity about this step: The API have the possibility to set the file name but I didn't implemented that at frontend.
from libresign.
Hi, I will reopen this issue and do a best check.
from libresign.
This is fixed for me in v8.0.0-rc9.
from libresign.
Tested in LibreSign 8.0.0-rc7 running on Nextcloud 28.0.2.
I logged in as the regular user, went to Settings > Notifications, and turned on the new "You have a file to sign" notfication:
Logging into Nextcloud as the admin user, I requested a signature from the regular user and waited for a notification to arrive via email. After a few minutes, this email arrived:
Although the email did arrive, it did not contain the information that I expected. As you can see, the email only says that "There was some activity at Nextcloud". At minimum, I expected the email to indicate that the activity that I am being notified about is that there is a new file to sign, and indicate what the name of the file is. It would also be great if there was a button that took the user to the file, but that is not strictly necessary.
In general, I would expect the notification email to either look like all the other activity notification emails that are sent by Nextcloud, or like the existing notification emails that LibreSign sends when a signature is requested from an email address
Here are some mockups:
Mock-up: LibreSign notification modeled on other activity notifications. (This is my preferred solution, since it integrates with with activity notifications the user is already receiving.)
Mock-up: LibreSign notification modeled on existing LibreSign emails.
from libresign.
Looking more closely at the emails, it appears that you might have already been attempting to use the standard activity emails, as in the first mock-up above. However, it looks like the activity didn't properly register.
In case it is important, I will point out that LibreSign did not add an activity notification in the Activities app either:
from libresign.
I reopened this issue to check more.
In my environment I'm receiving this email:
from libresign.
I just shared a file to see if I could get Files to generate an activity email, and everything seems to be working as expected outside of LibreSign:
I just checked, and the string "libresign" does not appear in nextcloud.log
.
from libresign.
Is working to me:
from libresign.
Let me turn off SELinux, reboot, and try again.
from libresign.
Did you enabled here? The last option.
from libresign.
Yes, the "You have a file to sign" activity is turned ON:
I have turned off SELinux and rebooted:
[ceperry@newton ~]$ sestatus
SELinux status: disabled
I uploaded a new document and requested a signature on the document. My next notification email showed the files activity of uploading the file, but there was no activity from LibreSign:
from libresign.
Not related about email, but I identified that Activity app have a class called Filter to be possible display the activities at Activity app. I'm implementing this now, maybe will help to check if you are receiving the notifications.
from libresign.
@DazeEnd could you check if is ok looking the screenshots here #2509 ?
I will wait your review to don't send new words to translators because this PR changed and created texts.
from libresign.
@vitormattos Sorry for the delay in getting back to you. The screenshots look good to me.
The notifications include the message, "admin requested your signature on document." In this message, will "document" be replaced with the name of the file? For example, "admin requested your signature on Perry Contract.pdf"? If yes, then it's fine.
However, if "document" will not be replaced, and it will always read "[username] requested your signature on document", then I think it should be slightly reworded to say "[username] requested your signature on a document".
from libresign.
Testing on RC8, this problem seems to be mostly fixed, but not completely fixed.
When I request a signature from a user with a Nextcloud account, the user whose signature was requested receives the following notifications:
- The user immediately receives an email informing him that his signature has been requested. (See "Screenshot 1", below.)
- The user later receives an activity email notifying the user that LibreSign made changes to a document. (See "Screenshot 2", below.)
- The user has an activity posted in the Activity app, saying that the requesting user made changes to a document. (See "Screenshot 3", below.)
What still seems to be missing is an activity indicating that someone "requested your signature" on the document, as illustrated in screenshots in #2509. (See "Screenshots from Issue 2509", below.)
from libresign.
Fixed by:
from libresign.
Fixed at: https://github.com/LibreSign/libresign/releases/download/v8.0.0-rc9/libresign-v8.0.0-rc9.tar.gz
from libresign.
Related Issues (20)
- Remove deprecated namespace of vfsStream at tests
- Error: PDFtk binary is invalid HOT 8
- About custom footer and its settings HOT 1
- Document not visible when singing from iOS
- Extended check for Java binaries. Support for Alpine/Nextcloud-AIO HOT 9
- Cannot set non existing property OCA\\Libresign\\Handler\\CertificateEngine\\CfsslHandler HOT 3
- Use attributes on Controller methods to define routes
- 404 invalid user - for links sent to users without an account HOT 1
- White page on opening signing document HOT 25
- Cannot Reinstall Java after Upgrade to v8.0.2 HOT 1
- Cannot set non existing property OCA\\Libresign\\Handler\\CertificateEngine\\CfsslHandler HOT 1
- User group for signing not saved HOT 2
- Search Signer field not responsive when sending document for signature
- After deleting the LibreSign folder the Nextcloud menu disappear
- CFSSL AUTHENTICATED SIGNER
- Implement loading when validate setup at LibreSign Administration settings HOT 1
- No way to return from the validation after signing
- Change the file list to be more similar to app Files
- JS error "cannot read properties of null (reading 'uuid')" when open details of a file HOT 12
- Enhancement Request: Vector Format Signature in Signed PDF Documents
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libresign.