Giter Site home page Giter Site logo

Bug in ocsp verifycation about openbsd HOT 5 CLOSED

libressl avatar libressl commented on July 16, 2024
Bug in ocsp verifycation

from openbsd.

Comments (5)

busterb avatar busterb commented on July 16, 2024

@4a6f656c is this https://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=4ca5efc2874e094d6382b30416824eda6dde52fe ?

from openbsd.

kinichiro avatar kinichiro commented on July 16, 2024

Does this issue relate to the ticket, here ?
https://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3668

I tested ocsp_test.c in that ticket, and got the results below.

With OpenSSL 1.0.2g, result is OK.

$ /usr/bin/openssl version
OpenSSL 1.0.2g-fips  1 Mar 2016
$ cc ocsp_test.c -I /usr/include -L /usr/lib -lcrypto -lssl
$ ldd a.out
        linux-vdso.so.1 =>  (0x00007ffce88f7000)
        libcrypto.so.1.0.0 => /lib/x86_64-linux-gnu/libcrypto.so.1.0.0 (0x00007f406e6dc000)
        libssl.so.1.0.0 => /lib/x86_64-linux-gnu/libssl.so.1.0.0 (0x00007f406e473000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f406e0a9000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f406dea5000)
        /lib64/ld-linux-x86-64.so.2 (0x000055850b26c000)
$ ./a.out www.amazon.com 443
OK
$

With LibreSSL 2.4.1, result is NG.

$ /usr/local/bin/openssl version
LibreSSL 2.4.1
$ cc ocsp_test.c -I /usr/local/include -L /usr/local/lib -lcrypto -lssl
$ ldd a.out
        linux-vdso.so.1 =>  (0x00007fffa99c5000)
        libcrypto.so.38 => /usr/local/lib/libcrypto.so.38 (0x00007fe9da7d7000)
        libssl.so.39 => /usr/local/lib/libssl.so.39 (0x00007fe9da57d000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fe9da1b3000)
        /lib64/ld-linux-x86-64.so.2 (0x000055d6462f3000)
$ ./a.out www.amazon.com 443
OCSP response verification failed
$

And if fix this problem, how about including another fix:
openssl/openssl@bea9a17

from openbsd.

bob-beck avatar bob-beck commented on July 16, 2024

Yeah, this looks to be the issue. we should address this in a similar way

from openbsd.

bob-beck avatar bob-beck commented on July 16, 2024

The attached (based on OpenBSD base) should fix it - It does for me here
using the ocsp_test program

On Mon, Jul 4, 2016 at 9:05 AM, kinichiro inoguchi <[email protected]

wrote:

Does this issue relate to the ticket, here ?
https://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3668

I tested ocsp_test.c in that ticket, and got the results below.

With OpenSSL 1.0.2g, result is OK.

$ /usr/bin/openssl version
OpenSSL 1.0.2g-fips 1 Mar 2016
$ cc ocsp_test.c -I /usr/include -L /usr/lib -lcrypto -lssl
$ ldd a.out
linux-vdso.so.1 => (0x00007ffce88f7000)
libcrypto.so.1.0.0 => /lib/x86_64-linux-gnu/libcrypto.so.1.0.0 (0x00007f406e6dc000)
libssl.so.1.0.0 => /lib/x86_64-linux-gnu/libssl.so.1.0.0 (0x00007f406e473000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f406e0a9000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f406dea5000)
/lib64/ld-linux-x86-64.so.2 (0x000055850b26c000)
$ ./a.out www.amazon.com 443
OK
$

With LibreSSL 2.4.1, result is NG.

$ /usr/local/bin/openssl version
LibreSSL 2.4.1
$ cc ocsp_test.c -I /usr/local/include -L /usr/local/lib -lcrypto -lssl
$ ldd a.out
linux-vdso.so.1 => (0x00007fffa99c5000)
libcrypto.so.38 => /usr/local/lib/libcrypto.so.38 (0x00007fe9da7d7000)
libssl.so.39 => /usr/local/lib/libssl.so.39 (0x00007fe9da57d000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fe9da1b3000)
/lib64/ld-linux-x86-64.so.2 (0x000055d6462f3000)
$ ./a.out www.amazon.com 443
OCSP response verification failed
$

And if fix this problem, how about including another fix:
openssl/openssl@bea9a17
openssl/openssl@bea9a17


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#45 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHv2deMfpBv1UW1FeogLHqyXYStefxphks5qSSEhgaJpZM4F8QZa
.

from openbsd.

bob-beck avatar bob-beck commented on July 16, 2024

Fixes commited to OpenBSD. should show up upstream soon.

from openbsd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.