Giter Site home page Giter Site logo

Comments (2)

Salamek avatar Salamek commented on September 7, 2024

In that case we need to change LIBRSYNC_MAJOR_VERSION to 2 (so version will be 2.0.1 or 2.0.0 ) cos this in CMakeLists.txt:

set_target_properties(rsync PROPERTIES VERSION ${LIBRSYNC_VERSION} SOVERSION ${LIBRSYNC_MAJOR_VERSION})

or just do

set_target_properties(rsync PROPERTIES VERSION ${LIBRSYNC_VERSION} SOVERSION 2)

but that is ugly... i think soversion should match major version... and cos there is librsync.so.2 "out there" binary compatible with 1.0.1... moving LIBRSYNC_MAJOR_VERSION to 2 is only ~clean solution

@sourcefrog ?

from librsync.

sourcefrog avatar sourcefrog commented on September 7, 2024

Hi, thanks for flagging this regression.

In previous versions of librsync I followed the advice in the libtool manual to allow the software release version and the library version to be different. See https://github.com/librsync/librsync/blob/e2d3bdf88bb792b4c022afddb2e8462e519d0bc2/libversions.txt.

However this is pretty crazy and confusing.

So I plan to fix this by just bumping the library version up to 2.0.0.

from librsync.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.