Reproducible crash on OpenBSD

[lichray]

Reproducible crash on OpenBSD

[bentley]

#0  seq_find (sp=0x17904beaec10, lastqp=0x0, e_input=0x179047703000,
    c_input=0x0, ilen=1, stype=SEQ_INPUT, ispartialp=0x7f7ffffddd7c)
    at /usr/ports/pobj/nvi-2.1.1-iconv/nvi-2.1.1/common/seq.c:236
#1  0x0000178e45f14587 in v_event_get (sp=0x17904fc3b630, argp=0x7f7ffffde1a0,
    timeout=0, flags=4)
    at /usr/ports/pobj/nvi-2.1.1-iconv/nvi-2.1.1/common/key.c:646
#2  0x0000178e45f42c84 in v_txt (sp=0x17904fc3b630, vp=0x7f7ffffde3f0, tm=Variable "tm" is not available.
)
    at /usr/ports/pobj/nvi-2.1.1-iconv/nvi-2.1.1/vi/v_txt.c:480
#3  0x0000178e45f3c3fc in v_ia (sp=0x17904fc3b630, vp=0x7f7ffffde3f0)
    at /usr/ports/pobj/nvi-2.1.1-iconv/nvi-2.1.1/vi/v_itxt.c:114
#4  0x0000178e45f3c54f in v_iA (sp=0x17904fc3b630, vp=0x7f7ffffde3f0)
    at /usr/ports/pobj/nvi-2.1.1-iconv/nvi-2.1.1/vi/v_itxt.c:77
#5  0x0000178e45f48531 in vi (spp=0x7f7ffffde608)
    at /usr/ports/pobj/nvi-2.1.1-iconv/nvi-2.1.1/vi/vi.c:229
#6  0x0000178e45f1778a in editor (gp=0x17904b81f000, argc=2,
    argv=0x7f7ffffde7f8)
    at /usr/ports/pobj/nvi-2.1.1-iconv/nvi-2.1.1/common/main.c:421
#7  0x0000178e45f0d4d1 in main (argc=2, argv=0x7f7ffffde7f0)
    at /usr/ports/pobj/nvi-2.1.1-iconv/nvi-2.1.1/cl/cl_main.c:120

[lichray]

Fixed after reproducing in FreeBSD. Thank you very much! I reworked the memory allocation macros some time ago, and it seems that the original nvi code does not always use the macros to manage memory.

Can you confirm the fix on OpenBSD as well? Thanks.

[bentley]

Can no longer reproduce the problem. Thanks!