Giter Site home page Giter Site logo

v2-beta: Remove Font Awesome about clay HOT 10 CLOSED

liferay avatar liferay commented on September 14, 2024
v2-beta: Remove Font Awesome

from clay.

Comments (10)

jbalsas avatar jbalsas commented on September 14, 2024

Makes sense. UX has specifically asked that only designed svg icons are shipped by default, so we are also going in this direction.

We just need to make sure we have a clear path for developers to add icon fonts and use them independently of what we ship in clay.

from clay.

yuchi avatar yuchi commented on September 14, 2024

If themes could depend on bundles then we could have FA3 and FA4 resource providers.

@jbalsas Can the new loader help on this? Are static packages’ resources available?

from clay.

jbalsas avatar jbalsas commented on September 14, 2024

Yeah, I think all resources are available when bundled using the new method. In any case, it sounds like these could go as ThemeContributors, for example.

from clay.

jbalsas avatar jbalsas commented on September 14, 2024

Just for clarification, we want to stop bundling the icon fonts in Clay, but we'll still figure out a way to provide them in Liferay Portal ootb.

from clay.

yuchi avatar yuchi commented on September 14, 2024

[…] these could go as ThemeContributors […]

Well, usually I think it’s a theme’s responsibility to bring the icon packs to the page but actually it’s more an editorial requiriment.

So from one side apps and themes should be able to “ask” for an icon pack, but also editors need to access them. Totally Out Of Topic™ but having a DDM field type “Icon” where you can choose one from the available icon packs would be totally awesome.

from clay.

jbalsas avatar jbalsas commented on September 14, 2024

ThemeContributors (albeit their bad name) add resources globally independently of the applied Theme. That's why it might be a good option to make them easily available. They double as themelets, so a themelet including FA4 could make it be always available if deployed as a ThemeContributor.

Out of Topic™, where and how would you use the Icon field? Is this something that should be needed inside the WYSWYG editors as well?

from clay.

yuchi avatar yuchi commented on September 14, 2024

Out of Topic™, for example if you are writing a list of features of a product (see this example from smc.it). Sometimes you have them as rasterized images, sometimes as SVG, sometimes as icons in the icon packs have in the page (typically font-awesome). Another very good case are Call to Actions and buttons (see later in that same page), where icons must be either icon fonts or vectorial.

from clay.

yuchi avatar yuchi commented on September 14, 2024

The perfect solution would be an icon chooser, configurable to accept (or not) files from the DM and/or icon fonts and/or SVG icons.

from clay.

yuchi avatar yuchi commented on September 14, 2024

Other examples where such a selector would have benefitted: click on a slice here (it’s a Web Content structure/tmpl), or look at «Servizi Online» in this page, or as AssetCategoryProperty values here.

from clay.

jbalsas avatar jbalsas commented on September 14, 2024

/cc @aaragueslr, @JorgeFerrer, @marcellustavares

from clay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.