ligh7s/smoked-salmon

salmon uploading tools~

smoked-salmon's Issues

Bandcamp scraper error

Error message: (ScrapeError(...), 'Could not parse record label.')

for example with this URL
https://warningberlin.bandcamp.com/album/war2002

Results in all of the metadata not getting grabbed.

Python 3.10+ support

When attempting to run this tool with a Python version of 3.10 or greater the following error occurs:

$ python3 run.py 
Traceback (most recent call last):
  File "/home/pog/smoked-salmon/run.py", line 7, in <module>
    import salmon.commands
  File "/home/pog/smoked-salmon/salmon/commands.py", line 10, in <module>
    import salmon.checks
  File "/home/pog/smoked-salmon/salmon/checks/__init__.py", line 12, in <module>
    from salmon.common import commandgroup
  File "/home/pog/smoked-salmon/salmon/common/__init__.py", line 59, in <module>
    prompt_async = Prompt()
  File "/home/pog/smoked-salmon/salmon/common/__init__.py", line 45, in __init__
    self.q = asyncio.Queue(loop=loop)
  File "/usr/lib/python3.10/asyncio/queues.py", line 33, in __init__
    super().__init__(loop=loop)
  File "/usr/lib/python3.10/asyncio/mixins.py", line 17, in __init__
    raise TypeError(
TypeError: As of 3.10, the *loop* parameter was removed from Queue() since it is no longer necessary

$ python3 --version
Python 3.10.1

iTunes Update

Changes to iTunes have caused iTunes integration to stop working.

iTunes Error

Scraping error..

(Vulnerablility) Use the unsafe component aiohttp causes path traversal

This can causes CVE-2024-23334

apple@MacBook-Pro ~ % curl --path-as-is "http://127.0.0.1:8888/static/../../../../../../../../../etc/passwd"
##
# User Database
# 
# Note that this file is consulted directly only when the system is running
# in single-user mode.  At other times this information is provided by
# Open Directory.
#
# See the opendirectoryd(8) man page for additional information about
# Open Directory.
##
nobody:*:-2:-2:Unprivileged User:/var/empty:/usr/bin/false
root:*:0:0:System Administrator:/var/root:/bin/sh
daemon:*:1:1:System Services:/var/root:/usr/bin/false
_uucp:*:4:4:Unix to Unix Copy Protocol:/var/spool/uucp:/usr/sbin/uucico
_taskgated:*:13:13:Task Gate Daemon:/var/empty:/usr/bin/false
_networkd:*:24:24:Network Services:/var/networkd:/usr/bin/false
_installassistant:*:25:25:Install Assistant:/var/empty:/usr/bin/false
_lp:*:26:26:Printing Services:/var/spool/cups:/usr/bin/false
_postfix:*:27:27:Postfix Mail Server:/var/spool/postfix:/usr/bin/false
_scsd:*:31:31:Service Configuration Service:/var/empty:/usr/bin/false

Request: Spotify - Soundcloud

• Soundcloud - Plenty of free Lossless audio files are distributed by different artists on this platform. Integrating with Salmon could facilitate uploads.

---

• Spotify - Adds to the listening experience, integrating a link alongside other sources would allow users to add music to their playlists, favorite songs, etc.

DOWNLOAD_DIRECTORY & DOWNLOAD_QUEUE_FOLDER? Not documented

Two options appear in the example config.py that I can't find in the documentation:
DOWNLOAD_DIRECTORY =
DOWNLOAD_QUEUE_FOLDER = '/path/to/folder/for/the/queue'

What are they supposed to do? They don't seem to do anything that I can see...

Spectral Encoder Output incorrect when uploaded to both RED and OPS

When running the specs command, the encoder specifics output always shows "Encode Specifics: 16 bit 41.4 kHz" on 24 bit 48kHz songs.

Artists removed in tagging process still get used in file tag changes?

See "proposed tag changes", and that the artist was removed

Pending metadata:
> TRACK COUNT   : 2
> ARTISTS:
>>>  BSN Posse [main]
>>>  Energy Man [main]
>>>  Manul [main]
>>>  Manu-L [main]
> TITLE         : SEVILLA TO MALAGA
> GROUP YEAR    : 2017
> YEAR          : 2017
> EDITION TITLE : None
> LABEL         : Below Music
> CATNO         : BLMS002
> UPC           : 191079431069
> GENRES        : Electro; Dance; Electronic; Breakbeat
> RELEASE TYPE  : Single
> COMMENT       : None
> URLS:
>>> https://listen.tidal.com/album/73893368
>>> https://www.deezer.com/album/41474461
>>> https://itunes.apple.com/us/album/1229180944
>>> https://junodownload.com/products/sevilla-to-malaga/3427254-02
>>> https://www.discogs.com/release/13285395

Are there any metadata fields you would like to edit? [a]rtists, artist a[l]iases, [t]itle, [g]enres, [r]elease type, [y]ears, [e]dition info, [c]omment, trac[k]s, [u]rls, [n]othing: a

Pending metadata:
> TRACK COUNT   : 2
> ARTISTS:
>>>  BSN Posse [main]
>>>  Energy Man [main]
>>>  Manul [main]
> TITLE         : SEVILLA TO MALAGA
> GROUP YEAR    : 2017
> YEAR          : 2017
> EDITION TITLE : None
> LABEL         : Below Music
> CATNO         : BLMS002
> UPC           : 191079431069
> GENRES        : Electro; Dance; Electronic; Breakbeat
> RELEASE TYPE  : Single
> COMMENT       : None
> URLS:
>>> https://listen.tidal.com/album/73893368
>>> https://www.deezer.com/album/41474461
>>> https://itunes.apple.com/us/album/1229180944
>>> https://junodownload.com/products/sevilla-to-malaga/3427254-02
>>> https://www.discogs.com/release/13285395

Are there any metadata fields you would like to edit? [a]rtists, artist a[l]iases, [t]itle, [g]enres, [r]elease type, [y]ears, [e]dition info, [c]omment, trac[k]s, [u]rls, [n]othing: n

Retagging files...

Proposed tag changes:
> 02. Right Now.flac
  artist               ••• BSN Posse, Energy Man, Manul >>> BSN Posse, Energy Man, Manu-L, Manul

Album tags (applied to all):
> album         ••• SEVILLA TO MALAGA
> genre         ••• None >>> Breakbeat; Dance; Electro; Electronic
> date          ••• 2017
> label         ••• Below Music
> catno         ••• None >>> BLMS002
> albumartist   ••• BSN Posse, Energy Man, Manul
> upc           ••• 191079431069

Mixtape not completely flensed

I've had a hell of a time this evening trying to figure out what in gods green earth mixtape is referring to. Fortunately enough breadcrumbs were left in the wiki, but searching the git logs, source code, and popular search engines left no clues.

(smoked-salmon) [~/Projects/gazelle/smoked-salmon]$ python3 ./run.py --help
The database needs updating. Please run `salmon migrate`.

Traceback (most recent call last):
  File "./run.py", line 7, in <module>
    import salmon.commands
  File "/home/redbeard/Projects/gazelle/smoked-salmon/salmon/commands.py", line 17, in <module>
    import salmon.uploader
  File "/home/redbeard/Projects/gazelle/smoked-salmon/salmon/uploader/__init__.py", line 40, in <module>
    from salmon.images import upload_cover
  File "/home/redbeard/Projects/gazelle/smoked-salmon/salmon/images/__init__.py", line 146, in <module>
    def upload_spectrals(spectrals, uploader=HOSTS[config.SPECS_UPLOADER], successful=None):
KeyError: 'mixtape'
(smoked-salmon) [~/Projects/gazelle/smoked-salmon]$ python3 ./run.py migrate
The database needs updating. Please run `salmon migrate`.

Traceback (most recent call last):
  File "./run.py", line 7, in <module>
    import salmon.commands
  File "/home/redbeard/Projects/gazelle/smoked-salmon/salmon/commands.py", line 17, in <module>
    import salmon.uploader
  File "/home/redbeard/Projects/gazelle/smoked-salmon/salmon/uploader/__init__.py", line 40, in <module>
    from salmon.images import upload_cover
  File "/home/redbeard/Projects/gazelle/smoked-salmon/salmon/images/__init__.py", line 146, in <module>
    def upload_spectrals(spectrals, uploader=HOSTS[config.SPECS_UPLOADER], successful=None):
KeyError: 'mixtape'

Finally setting SPECS_UPLOADER = 'catbox' solved the problem (I think), but (I'm guessing) more work needs to be done to finalize 0068d9e.

Syntax Error while migrating database

(.venv) [user@server .smoked-salmon]$ python3 run.py migrate
Traceback (most recent call last):
File "/home/user/.smoked-salmon/run.py", line 7, in
import salmon.commands
File "/home/user/.smoked-salmon/salmon/commands.py", line 11, in
import salmon.converter
File "/home/user/.smoked-salmon/salmon/converter/init.py", line 4, in
from salmon.converter.downconverting import convert_folder
File "/home/user/.smoked-salmon/salmon/converter/downconverting.py", line 13, in
from salmon.tagger.audio_info import gather_audio_info
File "/home/user/.smoked-salmon/salmon/tagger/init.py", line 19, in
from salmon.tagger.metadata import get_metadata
File "/home/user/.smoked-salmon/salmon/tagger/metadata.py", line 10, in
from salmon.search import SEARCHSOURCES, run_metasearch
File "/home/user/.smoked-salmon/salmon/search/init.py", line 15, in
from salmon.search import (
File "/home/user/.smoked-salmon/salmon/search/tidal.py", line 25
for rank in zip_longest((*await asyncio.gather(*tasks))):
^
SyntaxError: can't use starred expression here

dupe_checker error?

...REMOVED

error

Traceback (most recent call last):
File "/home/tuningman/.smoked-salmon/run.py", line 13, in
commandgroup(obj={})
File "/home/tuningman/.smoked-salmon/.venv/lib/python3.7/site-packages/click/core.py", line 764, in call
return self.main(*args, **kwargs)
File "/home/tuningman/.smoked-salmon/.venv/lib/python3.7/site-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/home/tuningman/.smoked-salmon/.venv/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/tuningman/.smoked-salmon/.venv/lib/python3.7/site-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/tuningman/.smoked-salmon/.venv/lib/python3.7/site-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/home/tuningman/.smoked-salmon/salmon/uploader/init.py", line 156, in up
spectrals_after=spectrals_after,
File "/home/tuningman/.smoked-salmon/salmon/uploader/init.py", line 296, in upload
request_id,
File "/home/tuningman/.smoked-salmon/salmon/uploader/upload.py", line 55, in prepare_and_upload
request_id,
File "/home/tuningman/.smoked-salmon/salmon/uploader/upload.py", line 131, in compile_data_new_group
"album_desc": generate_description(track_data, metadata),
File "/home/tuningman/.smoked-salmon/salmon/uploader/upload.py", line 231, in generate_description
t["t"].discnumber and int(t["t"].discnumber) > 1 for t in track_data.values()
File "/home/tuningman/.smoked-salmon/salmon/uploader/upload.py", line 231, in
t["t"].discnumber and int(t["t"].discnumber) > 1 for t in track_data.values()
ValueError: invalid literal for int() with base 10: '1/1'

I selected y" on upload the torrent, it uploaded the spectrals to ptpimg & then it broke.