Giter Site home page Giter Site logo

Comments (18)

Aleksandra0056 avatar Aleksandra0056 commented on July 23, 2024

Also, where is the original comment layout? Look at the screenshot earlier and look at this screenshot (It is thing for another issue, anyways sorry for off-topic):
image

  • These are comments from 5, May 2012 in “Me at the zoo” video from “jawed”
  • I think, that the original 2012 comments layout would be probably possible with CSS, but the comments pages “1, 2, 3, 4, 5, 6, 7, Next>>” would need JavaScript.

from customtube.

lightbeam24 avatar lightbeam24 commented on July 23, 2024

The reply button shouldn't overlap the like button in comments in Slovak (Slovenčina) language, nor in any other language.

Yeah, see, CustomTube only truly supports English at the moment. I have already fixed a major bug that happened in every language other than English, but supporting every language individually is something that is going to be very difficult to do, since I only speak English.

I do have an idea for how to fix the reply button specifically in other languages though.

The “Show less” line shouldn't overlap the video description.

Make sure you click the "Show more" button itself. Clicking the description itself also expands the description, just like in regular YouTube. I don't know how to explain it properly so here's some screenshots (took a random video for the description):

This happens when you click on the description (NOT the "Show more" button):

clicked on desc

This happens when you click on the "Show more" button specifically:

clicked on btn

I don't know why this happens, and fixing it is not really a priority.

Also, where is the original comment layout? Look at the screenshot earlier and look at this screenshot (It is thing for another issue, anyways sorry for off-topic):

It's planned. See, CustomTube was released because I felt like it was "good enough" for general use, but it is not actually finished. Any inaccuracy in CustomTube is something I'm most likely aware of, but haven't gotten around to yet.

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on July 23, 2024

Thank you, that you will implement old comments! Good luck with implementing old comments (And mainly good luck with all your work).

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on July 23, 2024

And I said:

I think, that the original 2012 comments layout would be probably possible with CSS, but the comments pages “1, 2, 3, 4, 5, 6, 7, Next>>” would need JavaScript.

I'm right?

from customtube.

lightbeam24 avatar lightbeam24 commented on July 23, 2024

And I said:

I think, that the original 2012 comments layout would be probably possible with CSS, but the comments pages “1, 2, 3, 4, 5, 6, 7, Next>>” would need JavaScript.

I'm right?

Yes. I'm not sure if I'll even be implementing the pagination.

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on July 23, 2024

And, you are planning to implement JavaScript someday to CustomTube? Because this is using only CSS.

from customtube.

lightbeam24 avatar lightbeam24 commented on July 23, 2024

And, you are planning to implement JavaScript someday to CustomTube? Because this is using only CSS.

Incorrect, the extension is already 27.5% JavaScript. Plus, I've already "Implemented JavaScript" in some ways. For example:

CustomElements

That is not YouTube's regular view count element. CustomTube created it using JavaScript. Same with the Like to Dislike bar.

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on July 23, 2024

Then sorry. But similarity to real layout is important, so I think, that the pagination should be implemented.

from customtube.

lightbeam24 avatar lightbeam24 commented on July 23, 2024

Then sorry. But similarity to real layout is important, so I think, that the pagination should be implemented.

Yes, a 100% accurate recreation would be ideal, but It might not be feasible. The reason I'm not guaranteeing pagination is because I've already tried to disable infinite scrolling on the comments (which would add a "Show more" button), but it proves to be more difficult than disabling the infinite scrolling of the related videos section for example.

If disabling infinite scrolling is hard, then pagination will be even harder.

Edit: Basically, the comment section is a pain to work with when you mess with the scrolling.

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on July 23, 2024

This is beginning to feels like a discussion to me (this issue), because there are 9 comments.
Anyways, can I create a new issue about these old (old-school) comments to have better control of it?

from customtube.

lightbeam24 avatar lightbeam24 commented on July 23, 2024

I mean you can if you want, but I mean, I'm already aware it. In fact, most of the things you brought up are things I was already aware of. The big exception being the PocketTube thing.

Edit: Besides, having the proper comment section is an improvement, not a fix.

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on July 23, 2024

So, I decided to create that issue, so at least we could have better control of it (e.g. If you accidentally forgot about that; Or if someone doesn't know, what feature you have to plan).

I will add a “Feature request:” pre-fix to it.

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on July 23, 2024

Yeah, see, CustomTube only truly supports English at the moment. I have already fixed a major bug that happened in every language other than English, but supporting every language individually is something that is going to be very difficult to do, since I only speak English.

That is not a language issue, but a CSS issue, because the “Odpovedať” is a longer word than “Reply”.

from customtube.

lightbeam24 avatar lightbeam24 commented on July 23, 2024

“Odpovedať” is a longer word than “Reply”.

That's exactly why it's a language issue.

The fix I've decided on:

CustomTube adds CSS which puts the reply button on the left, rather than the right. I now realize that the method it uses is not practical for multiple languages though. So I've decided that for all languages other than English, the reply button will stay on the end on the comment, as it is in regular YouTube. Less accurate, but only slightly.

from customtube.

lightbeam24 avatar lightbeam24 commented on July 23, 2024

The reply button fix has been applied in update 1.0.4. Should I close the issue?

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on July 23, 2024

Wait, I will test it.

from customtube.

Aleksandra0056 avatar Aleksandra0056 commented on July 23, 2024

Yes, it is fixed. And for the “show less”, then it was caused by “Enhancer for YouTube” extension, so I disabled that feature which was glitching it.

from customtube.

lightbeam24 avatar lightbeam24 commented on July 23, 2024

Alright, thanks.

from customtube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.