Comments (19)
πΆ Please release me, let me go πΆ
from jardiff.
@SethTisue Now that I think about it can you hold off the patch release until #155 is done? I will try and do it tomorrow (shouldn't be too hard) but the reasoning is that currently its publishing cli related stuff along with Main
which doesn't make sense
from jardiff.
sure, fine with me. see also #156
from jardiff.
#158 adds release steps to the repo (RELEASING.md
)
from jardiff.
@mdedetrich I added the secrets (using my personal Sonatype account, which has permissions for com.lightbend publishing)
from jardiff.
after publishing, I'll need to revise retronym/homebrew-formulas#5
from jardiff.
@mdedetrich I can't remember where I left off on this. Like was I waiting for something else to happen? If you can't think of anything that's still pending, I guess I should try to push a tag? (There was #153, but since it hasn't progressed, maybe we should release anyway and figure on releasing again if a fix comes in.)
from jardiff.
Yeah I was actually expecting a release at some point, the Windows fix can wait
from jardiff.
(release steps from RELEASING.md)
Core JAR
- create and tag the release via the GitHub web UI
- check the GitHub Actions log to see that publishing succeeded
- wait for the artifact to appear on Maven Central
CLI jar
- locally, on JDK 8, run
sbt cli/assembly
- rename the resulting JAR to just
jardiff.jar
- attach the JAR to the release in the GitHub web UI
- PR the change to the homebrew formula, using
shasum -a 256 jardiff.jar
to compute the SHA
from jardiff.
@mdedetrich no publish job was triggered. there must have been a flaw in #152 ? is it obvious to you what went wrong here?
I'm not used to a setup with everything in ci.yml
βΒ all the repos I work on have separate ci.yml
and release.yml
. also I'm not familiar with sbt-github-actions, so I'm hoping you can look into this yourself
from jardiff.
@mdedetrich no publish job was triggered. there must have been a flaw in #152 ? is it obvious to you what went wrong here?
I'm not used to a setup with everything in
ci.yml
βΒ all the repos I work on have separateci.yml
andrelease.yml
. also I'm not familiar with sbt-github-actions, so I'm hoping you can look into this yourself
Did you push a tag? Pushing a tag with the vx.x.x
pattern is what forces a publish and judging from https://github.com/lightbend-labs/jardiff/tags the last tag was pushed 2 weeks ago?
EDIT: So there is this screen
Which I guess is referring to the commit and not when it was pushed? Either case im looking into it.
from jardiff.
So I just checked the logs and it did trigger https://github.com/lightbend-labs/jardiff/actions/runs/6962890536/job/18947517194 and publish, it should be available by now?
from jardiff.
Huh, I don't remember that being there when I looked, maybe Actions was backed up or something π€·
(btw the job shows up with the name "Clean", is that easily fixable?)
https://github.com/lightbend-labs/jardiff/releases/tag/v1.9.0
available: https://central.sonatype.com/artifact/com.lightbend/jardiff-core_2.13
from jardiff.
@mdedetrich thanks for the help with this!
from jardiff.
(btw the job shows up with the name "Clean", is that easily fixable?)
There are 2 jobs, clean and continuous integration.
The actual publish is done in continuous integration and it only triggers if you happen to push a tag, which you can find here https://github.com/lightbend-labs/jardiff/actions/runs/6962890536
See how both the publish job is triggered and in the top left you see "Continuous Integration"
from jardiff.
Got it π
from jardiff.
@SethTisue Did you end up making a homebrew release of the new version?
from jardiff.
@mdedetrich I need Jason to merge retronym/homebrew-formulas#5 . I'll ping him.
from jardiff.
'tis merged
from jardiff.
Related Issues (20)
- Add support for Java 17 HOT 3
- Roll a release HOT 5
- Publish jardiff to maven HOT 3
- Roll another release HOT 1
- Add Windows support HOT 5
- Split core into core and cli sbt subprojects
- Publishing even when tag not pushed? HOT 5
- CI publishing jobs are failing HOT 1
- Add an option to suppress private members
- Add option to use javap instead of asm HOT 2
- Diff not showing removed classes
- jardiff writes to inaccessible directories by default HOT 1
- Exclude files from diff calculation HOT 2
- Add support for WAR archives HOT 1
- Error: Illegal character in opaque part at index 47 HOT 7
- Error when trying to compare Scala jars HOT 4
- Homebrew formula is warning about Java dependency
- Homebrew isn't recognizing the formula? HOT 4
- java.nio.file.FileSystemException: Incorrect function HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jardiff.