Giter Site home page Giter Site logo

Comments (6)

ennru avatar ennru commented on August 16, 2024

Sure, I would be OK with switching to highlightjs and dropping prettify.

Are you in a position to suggest the necessary changes in a PR?

from paradox.

harpocrates avatar harpocrates commented on August 16, 2024

Are you in a position to suggest the necessary changes in a PR?

Not yet - I wanted to check this would be well-received first before moving forward with the actual changes. Are you sure it is OK to drop prettify, or should it be kept around as an option (checking as I imagine highlightjs will have subtly different syntax definitions and color schemes such that code in existing doc projects like akka-docs might end up looking slightly different)?

from paradox.

ennru avatar ennru commented on August 16, 2024

I don't think it is a problem if the syntax colouring slightly changes. highlightjs seems to offer a vast set of predefined designs. Configuring that will be more useful than switching between prettify and highlightjs.

from paradox.

harpocrates avatar harpocrates commented on August 16, 2024

OK thanks; that definitely lowers the bar for changes I'd have to make/test. I'll aim to open a PR for this in the next week or so.

from paradox.

raboof avatar raboof commented on August 16, 2024

Going straight for highlightjs seems fine to me too.

I'm not sure if the fiddle integration interacts with the syntax highlighting at all - that might be one thing to double-check.

from paradox.

pvlugter avatar pvlugter commented on August 16, 2024

Switching to highlightjs sounds good to me too. Thanks @harpocrates

from paradox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.