Comments (6)
Excellent find! I'm not sure how we missed this the first time around...
I think your suggested solution is pretty straightforward. To eliminate the circular dependency nodes simply sign the channel auth digest (channelID+Bitcoin keys), leaving out the other parties signature from that digest.
Additionally, I think we need to enforce an additional constraint on the signatures within the announcement themselves. In order for us to possibly implement hash-based state reconciliation (rsync algo, hash time series, Patricia trie, etc), we need to ensure that only one encoding of the signature is accepted. Otherwise, our encoding won't be deterministic. In order words, we should enforce a low S (just like in Bitcoin) encoding for all announcement signatures propagated within the network.
from bolts.
Actually re-reading the spec I think we are mixing a few concerns here, the funding_locked
message, which is part of the channel lifecycle messages are being misused to also transfer the signatures. Maybe we should split the signatures out into their own messages? That way we would have explicit opt-in to channel announcements by both parties.
And is there a point to also signing the signatures at all? Maybe we should reorder fields so that we have the 4 signatures at the beginning and they simply sign everything below the signature fields (offset 256):
[64:node-signature-1]
[64:node-signature-2]
[64:bitcoin-signature-1]
[64:bitcoin-signature-2]
[8:channel-id]
[33:node-id-1]
[33:node-id-2]
[33:bitcoin-key-1]
[33:bitcoin-key-2]
[2:len]
[len:features]
from bolts.
is there a point to also signing the signatures at all?
I think you're right, signing the node ids & bitcoin keys is enough and it's easier to implement this way 👍
from bolts.
from bolts.
from bolts.
The chicken-and-egg problem should be addressed by #96, while the discussion about splitting off the signature exchange from the channel lifecycle is being tracked in #97. Seems this is fixed, closing 😉
from bolts.
Related Issues (20)
- Lightning Specification Meeting 2024/02/12 HOT 1
- [feature] Allow the recovering of (outgoing) HTLCs in a DLP case. HOT 3
- Lightning Specification Meeting 2024/02/26 HOT 4
- to_self_delay cannot be updated after opening a channel HOT 3
- Lightning Specification Meeting 2024/03/11 HOT 1
- Lightning Specification Meeting 2024/03/25 HOT 2
- Lightning Specification Meeting 2024/04/08 HOT 3
- Lightning Specification Meeting 2024/04/22 HOT 10
- BOLT-4: Decrypt onion using b_i or k_i HOT 2
- Lightning Specification Meeting 2024/05/06 HOT 4
- Lightning Specification Meeting 2024/05/20 HOT 3
- Add support for bundled payments in BOLT12 HOT 1
- Lightning Specification Meeting 2024/06/03 HOT 2
- BOLT-11: add optional feature bit to indicate delayed settlement of invoice HOT 7
- Lightning Dev Summit Topics HOT 3
- Lightning Specification Meeting 2024/06/17 HOT 1
- Discussion: some confusion re blinded path `max_cltv` HOT 2
- Lightning Specification Meeting 2024/07/01 HOT 1
- Lightning Specification Meeting 2024/07/15 HOT 1
- missing bolt11 example where `n` field must be verified by reader
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bolts.