Giter Site home page Giter Site logo

Comments (2)

rawtxapp avatar rawtxapp commented on May 13, 2024

This looks like a relatively good first issue, I'd like to take a stab at it if it isn't assigned to anyone, what do you think @Roasbeef ? If yes,

I looked through the code and instead of putting the caching inside GetCfilter, what do you think of putting it directly inside the FilterStore ? It seems like a logical place and that way GetCfilter logic would stay the same (other than just passing an extra persistToDisk bool to PutFilter).

For the LRU, what do you think of using an existing lib like golang-lru ? It also has Adaptive Replacement Cache and TwoQueueCache implementations that we could experiment with.

from neutrino.

Roasbeef avatar Roasbeef commented on May 13, 2024

Ideally we don't bring in additional lib just to implement an LRU cache. Also this should be done outside of the FilterStore all together. This is a caching layer that sits on top of the filter store.

from neutrino.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.