Giter Site home page Giter Site logo

Issue: Handicap about gobandroid HOT 9 CLOSED

labriola avatar labriola commented on June 15, 2024
Issue: Handicap

from gobandroid.

Comments (9)

ligi avatar ligi commented on June 15, 2024

that matches with whats stated in wikipedia - but I dont know how to make it transparent to the user what is happening - he would not see the difference beteween no handicap and a handicap of 1 until the game ended
Perhaps i will find a way to do this but right now i leave it as it is - i think its not an big issue

from gobandroid.

labriola avatar labriola commented on June 15, 2024

When you set a handicap of 1, black's stone is automatically placed. Data I can find suggests black still plays the stone but gives no komi. Not a big deal

from gobandroid.

oren740 avatar oren740 commented on June 15, 2024

The term of handicap of 1 is a bit odd since handicap number refers to the number of handicap stones placed. A rank difference of 1 usually means what you're describing of take black with no komi. I do agree the logic should change so a handicap of 1 does what you're suggesting though.

from gobandroid.

oren740 avatar oren740 commented on June 15, 2024

Checked in code so handicap stones placed when 2 or more, komi of 0 with any handicap. Hopefully this works for everyone.

Note that you can only use handicap on sizes 9,13,19 size boards.

from gobandroid.

oren740 avatar oren740 commented on June 15, 2024

Should this be closed now?

from gobandroid.

gthazmatt avatar gthazmatt commented on June 15, 2024

For as long as I've been using it (including currently), komi is still 6.5 when there are handicap stones. Also, as was mentioned in the original post, the handicap stones for 6 and 8 stones are misplaced. As I use the app for recording games, it has made a few a little difficult.

from gobandroid.

ligi avatar ligi commented on June 15, 2024

ok to boil down this issue

  • set komi to 0 if handicap is 2 stones or more
  • correct handicap placing for 6 and 8 stones

?

from gobandroid.

gthazmatt avatar gthazmatt commented on June 15, 2024

Essentially, although a handicap of 1 stone should also have no komi. I suppose it's not terribly useful as the difference between 1 stone and 2 stones is 4 points, but that's convention. Also, it's common to use 0.5 rather than 0 to avoid a tie.

I made a fork and made a change GoGame.java that I believe does both of these things, but since it was 2 in the morning, I didn't test it. In particular, I don't know offhand if this updates the komi value in the metadata. When I get home tonight, I'll try to test it and submit a pull request unless you work on it before then.

from gobandroid.

ligi avatar ligi commented on June 15, 2024

thanks - looks good to me now - you are right with the removing - PS: do you have a Google+ Page where I can link to for your credit and cirlce you into the contributor circle?

from gobandroid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.