Giter Site home page Giter Site logo

Rename the Twig filter about liipimaginebundle HOT 6 CLOSED

liip avatar liip commented on May 20, 2024
Rename the Twig filter

from liipimaginebundle.

Comments (6)

LouTerrailloune avatar LouTerrailloune commented on May 20, 2024

Sure, but who is going to use the 2 bundles in the same application ?

from liipimaginebundle.

stof avatar stof commented on May 20, 2024

well, maybe nobody, but we should not make it broken by design. This is also the reason why both bundles use different namespaces.

from liipimaginebundle.

lsmith77 avatar lsmith77 commented on May 20, 2024

I agree that we shouldn't change the name just to enable coexistence .. but it seems that the case is being made in #11 that we should rename for other reasons anyway ..

from liipimaginebundle.

stof avatar stof commented on May 20, 2024

btw, the new name should make clear that it is related to imagine IMO. apply_filter is pretty bad about explicitness

from liipimaginebundle.

lsmith77 avatar lsmith77 commented on May 20, 2024

good point.

from liipimaginebundle.

 avatar commented on May 20, 2024

Fixed in b00818e

from liipimaginebundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.